Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: net/cert/multi_log_ct_verifier_unittest.cc

Issue 92443002: Extract Certificate Transparency SCTs from stapled OCSP responses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract_scts
Patch Set: fix format errors Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/multi_log_ct_verifier_unittest.cc
diff --git a/net/cert/multi_log_ct_verifier_unittest.cc b/net/cert/multi_log_ct_verifier_unittest.cc
index 30d92b8e63733e48db04fce6a0eac75209d38091..b1d1aa889e8d0ffbc8db9b5ea55b7884f2c49c6e 100644
--- a/net/cert/multi_log_ct_verifier_unittest.cc
+++ b/net/cert/multi_log_ct_verifier_unittest.cc
@@ -83,7 +83,8 @@ class MultiLogCTVerifierTest : public ::testing::Test {
CapturingNetLog net_log;
BoundNetLog bound_net_log =
BoundNetLog::Make(&net_log, NetLog::SOURCE_CONNECT_JOB);
- return (verifier_->Verify(chain, "", "", &result, bound_net_log) == OK) &&
+ return (verifier_->Verify(chain, std::string(), std::string(), &result,
+ bound_net_log) == OK) &&
CheckForSingleVerifiedSCTInResult(result) &&
CheckForSCTOrigin(
result, ct::SignedCertificateTimestamp::SCT_EMBEDDED) &&
@@ -141,7 +142,8 @@ TEST_F(MultiLogCTVerifierTest,
ct::CTVerifyResult result;
EXPECT_EQ(OK,
- verifier_->Verify(chain_, "", sct_list, &result, BoundNetLog()));
+ verifier_->Verify(chain_, std::string(), sct_list, &result,
+ BoundNetLog()));
ASSERT_TRUE(CheckForSingleVerifiedSCTInResult(result));
ASSERT_TRUE(CheckForSCTOrigin(
result, ct::SignedCertificateTimestamp::SCT_FROM_TLS_EXTENSION));
@@ -160,7 +162,8 @@ TEST_F(MultiLogCTVerifierTest,
ct::CTVerifyResult result;
EXPECT_NE(OK,
- verifier_->Verify(chain_, sct_list, "", &result, BoundNetLog()));
+ verifier_->Verify(chain_, std::string(), sct_list, &result,
+ BoundNetLog()));
EXPECT_EQ(1U, result.unknown_logs_scts.size());
EXPECT_EQ("", result.unknown_logs_scts[0]->log_description);
}

Powered by Google App Engine
This is Rietveld 408576698