Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: net/cert/ct_objects_extractor.h

Issue 92443002: Extract Certificate Transparency SCTs from stapled OCSP responses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extract_scts
Patch Set: review comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_CERT_CT_OBJECTS_EXTRACTOR_H_ 5 #ifndef NET_CERT_CT_OBJECTS_EXTRACTOR_H_
6 #define NET_CERT_CT_OBJECTS_EXTRACTOR_H_ 6 #define NET_CERT_CT_OBJECTS_EXTRACTOR_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "net/base/net_export.h" 10 #include "net/base/net_export.h"
(...skipping 27 matching lines...) Expand all
38 38
39 // Obtains an X509Chain log entry for |leaf|, an X.509v3 certificate that 39 // Obtains an X509Chain log entry for |leaf|, an X.509v3 certificate that
40 // is not expected to contain an X.509v3 extension with the OID 40 // is not expected to contain an X.509v3 extension with the OID
41 // 1.3.6.1.4.1.11129.2.4.2 (meaning a certificate without an embedded SCT). 41 // 1.3.6.1.4.1.11129.2.4.2 (meaning a certificate without an embedded SCT).
42 // On success, fills |result| with the data for an X509Chain log entry and 42 // On success, fills |result| with the data for an X509Chain log entry and
43 // returns true. 43 // returns true.
44 // The filled |*result| should be verified using ct::CTLogVerifier::Verify 44 // The filled |*result| should be verified using ct::CTLogVerifier::Verify
45 NET_EXPORT_PRIVATE bool GetX509LogEntry(X509Certificate::OSCertHandle leaf, 45 NET_EXPORT_PRIVATE bool GetX509LogEntry(X509Certificate::OSCertHandle leaf,
46 LogEntry* result); 46 LogEntry* result);
47 47
48 // Extracts a SignedCertificateTimestampList that has been embedded within
49 // an OCSP response as an extension with the OID 1.3.6.1.4.1.11129.2.4.5.
50 // If the extension is present, and matches the serial number of the leaf
51 // certificate, returns true, updating |*sct_list| to contain
52 // the encoded list, minus the DER encoding necessary for the extension.
53 // |*sct_list| can then be further decoded with ct::DecodeSCTList.
54 //
55 // TODO(ekasper): change this to match by the entire CertID in an OCSP response.
56 // We currently do response matching by serial number only, so if the response
57 // contains statuses for different certificates with the same serial number,
58 // this method does not work. However, repeating serial numbers within the same
59 // OCSP response are unlikely to begin with (different CAs would have to be
60 // using the same serial number AND delegating to the same OCSP responder),
61 // and since CT further only uses stapled OCSP responses which are known to
62 // pertain to the server (leaf) certificate, this is a very low concern for us.
63 NET_EXPORT_PRIVATE bool ExtractSCTListFromOCSPResponse(
64 X509Certificate::OSCertHandle leaf,
wtc 2013/12/03 21:04:25 Nit: If CT can also be used for CA certificates, I
ekasper 2013/12/04 19:25:15 I've changed it to take a serial number directly.
65 const std::string& ocsp_response,
66 std::string* sct_list);
67
48 } // namespace ct 68 } // namespace ct
49 69
50 } // namespace net 70 } // namespace net
51 71
52 #endif // NET_CERT_CT_OBJECTS_EXTRACTOR_H_ 72 #endif // NET_CERT_CT_OBJECTS_EXTRACTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698