Remove FontConfigTypeface::getFamilyName().

src/ports/SkFontHost_fontconfig.cpp

 /*
  * Copyright 2008 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkFontConfigInterface.h"
 #include "SkFontConfigTypeface.h"
 #include "SkFontDescriptor.h"
@@ skipping 67 matching lines @@
 
 SkTypeface* FontConfigTypeface::LegacyCreateTypeface(
                 const SkTypeface* familyFace,
                 const char familyName[],
                 SkTypeface::Style style) {
     SkAutoTUnref<SkFontConfigInterface> fci(RefFCI());
     if (NULL == fci.get()) {
         return NULL;
     }
 
+    SkString familyFaceName;
     if (familyFace) {

[bungeman-skia, 2015/02/18 21:05:49]

It turns out we never actually come down this path. This block is removed in a
follow up CL.

-        FontConfigTypeface* fct = (FontConfigTypeface*)familyFace;
-        familyName = fct->getFamilyName();
+        familyFace->getFamilyName(&familyFaceName);
+        familyName = familyFaceName.c_str();
     }
 
     SkFontStyle requestedStyle(style);
     FindRec rec(familyName, requestedStyle);
     SkTypeface* face = SkTypefaceCache::FindByProcAndRef(find_proc, &rec);
     if (face) {
         //SkDebugf("found cached face <%s> <%s> %p [%d]\n",
         //         familyName, ((FontConfigTypeface*)face)->getFamilyName(),
         //         face, face->getRefCnt());
         return face;
@@ skipping 36 matching lines @@
     SkAutoTUnref<SkFontConfigInterface> fci(RefFCI());
     if (NULL == fci.get()) {
         return NULL;
     }
 
     *ttcIndex = this->getIdentity().fTTCIndex;
     return fci->openStream(this->getIdentity());
 }
 
 void FontConfigTypeface::onGetFamilyName(SkString* familyName) const {
-    *familyName = this->getFamilyName();
+    *familyName = fFamilyName;
 }
 
 void FontConfigTypeface::onGetFontDescriptor(SkFontDescriptor* desc,
                                              bool* isLocalStream) const {
-    desc->setFamilyName(this->getFamilyName());
+    SkString name;
+    this->getFamilyName(&name);
+    desc->setFamilyName(name.c_str());
     desc->setFontIndex(this->getIdentity().fTTCIndex);
     *isLocalStream = SkToBool(this->getLocalStream());
 }