Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 924333003: Remove FontConfigTypeface::getFamilyName(). (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
reed2, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove FontConfigTypeface::getFamilyName(). This method is hiding a method of the same name from the superclass. This is confusing and error prone, and doesn't really add anything. Committed: https://skia.googlesource.com/skia/+/cd87c51de6bf81ed232b5d828c88771829c0bf76

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/ports/SkFontConfigTypeface.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 2 chunks +7 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
bungeman-skia
5 years, 10 months ago (2015-02-18 16:43:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924333003/1
5 years, 10 months ago (2015-02-18 17:39:47 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-18 17:39:48 UTC) #5
bungeman-skia
https://codereview.chromium.org/924333003/diff/1/src/ports/SkFontHost_fontconfig.cpp File src/ports/SkFontHost_fontconfig.cpp (right): https://codereview.chromium.org/924333003/diff/1/src/ports/SkFontHost_fontconfig.cpp#newcode89 src/ports/SkFontHost_fontconfig.cpp:89: if (familyFace) { It turns out we never actually ...
5 years, 10 months ago (2015-02-18 21:05:49 UTC) #6
reed2
lgtm
5 years, 10 months ago (2015-02-18 21:21:18 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 21:22:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd87c51de6bf81ed232b5d828c88771829c0bf76

Powered by Google App Engine
This is Rietveld 408576698