Source/core/html/HTMLMediaElement.cpp - Issue 924273004: Remove HTMLMediaElement::textTrackKindChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 924273004: Remove HTMLMediaElement::textTrackKindChanged (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add FIXME+bugref. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 23ba1efbfe7eab84dee7b489679d6b4c1a681d4e..7d5ac688dd01e7e5b011b4408bf50c3f087815fa 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -1184,12 +1184,6 @@ void HTMLMediaElement::textTrackModeChanged(TextTrack* track)

textTracks()->scheduleChangeEvent();

}

-void HTMLMediaElement::textTrackKindChanged(TextTrack* track)

- if (track->kind() != TextTrack::captionsKeyword() && track->kind() != TextTrack::subtitlesKeyword() && track->mode() == TextTrack::showingKeyword())

- track->setMode(TextTrack::hiddenKeyword());

bool HTMLMediaElement::isSafeToLoadURL(const KURL& url, InvalidURLAction actionIfInvalid)

{

if (!url.isValid()) {

« no previous file with comments | « Source/core/html/HTMLMediaElement.h ('k') | Source/core/html/track/TextTrack.cpp » ('j') | no next file with comments »