[NaCL SDK] Add initial support for nacl-clang

[NaCL SDK] Add initial support for nacl-clang

This adds 'clang-newlib' as new possible value for
$TOOLCHAIN and enables building of most examples
and libraries with the new toolchain.

Initially adding without ARM support.  ARM support
will follow shortly.

Also, update buildbot_common.py to output shorter
filenames (making output easier to read).

BUG=454962
Committed: https://crrev.com/edbe84670e56798b194943dd567a9c38e1d41a6b
Cr-Commit-Position: refs/heads/master@{#316672}

[Sam Clegg, 2015-02-14 01:42:32]

sbc@chromium.org changed reviewers:
+ binji@chromium.org, dschuff@chromium.org

[Derek Schuff, 2015-02-17 17:52:26]

most of this code is unfamiliar to me. I'm happy to look through it and see if I
see any obvious misuse of the toolchain or whatever, but is there anything in
particular I should be looking for?

[Sam Clegg, 2015-02-17 18:35:58]

On 2015/02/17 17:52:26, Derek Schuff wrote:
> most of this code is unfamiliar to me. I'm happy to look through it and see if
I
> see any obvious misuse of the toolchain or whatever, but is there anything in
> particular I should be looking for?

I guess I meant to CC you really, in case you see any claring issues.

ben should be the primary review on this.

[Sam Clegg, 2015-02-17 20:19:17]

sbc@chromium.org changed reviewers:
+ bradnelson@chromium.org
- binji@chromium.org, dschuff@chromium.org

[bradn, 2015-02-17 20:21:47]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2015-02-17 20:21:49]

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:451: xarches = (None, 'ia32',
'x64')
why isn't arm in here?
I thought it now works for arm?

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:602: ['use_nacl_clang=1'])
arm?

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:662: 'pnacl')
Why do these both have pnacl on the end?

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/buildbot_common.py (right):

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/buildbot_common.py:161: if drive and drive !=
os.path.splitdrive(SRC_DIR)[0]:
Why is this needed now?

[Sam Clegg, 2015-02-17 20:31:13]

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:451: xarches = (None, 'ia32',
'x64')
On 2015/02/17 20:21:48, bradn wrote:
> why isn't arm in here?
> I thought it now works for arm?

See my other comment.

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:602: ['use_nacl_clang=1'])
On 2015/02/17 20:21:47, bradn wrote:
> arm?

When I started this change there was no arm support.  I could add it now if you
think thats is better, or add it in another CL.

Trying it locally now.

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:662: 'pnacl')
On 2015/02/17 20:21:48, bradn wrote:
> Why do these both have pnacl on the end?

See NACL_HEADER_MAP.

In both cases the set of headers we are installing are the pnacl
headers, which are basically the newlib headers.

We install them in le32-nacl/include and in x86_64-nacl/include
but they are the same headers.

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/buildbot_common.py (right):

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/buildbot_common.py:161: if drive and drive !=
os.path.splitdrive(SRC_DIR)[0]:
On 2015/02/17 20:21:48, bradn wrote:
> Why is this needed now?

Its not needed, its just makes the output easier to read when debugging.  Want
me to move to a different CL?

[bradn, 2015-02-17 20:33:49]

lgtm

If arm proves tricky, feel free to land as is, and add in a separate CL.

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/buildbot_common.py (right):

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/buildbot_common.py:161: if drive and drive !=
os.path.splitdrive(SRC_DIR)[0]:
On 2015/02/17 20:31:12, Sam Clegg wrote:
> On 2015/02/17 20:21:48, bradn wrote:
> > Why is this needed now?
> 
> Its not needed, its just makes the output easier to read when debugging.  Want
> me to move to a different CL?

No that's fine, mention in change description?

[Sam Clegg, 2015-02-17 22:16:27]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2015-02-17 22:17:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/924253002/1

[commit-bot: I haz the power, 2015-02-17 22:22:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-17 22:23:45]

Patchset 1 (id:??) landed as
https://crrev.com/edbe84670e56798b194943dd567a9c38e1d41a6b
Cr-Commit-Position: refs/heads/master@{#316672}

[binji, 2015-02-20 18:34:22]

binji@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2015-02-20 18:34:23]

lgtm w/ a couple nits

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
File native_client_sdk/src/build_tools/build_sdk.py (right):

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:109: print arch
remove?

https://codereview.chromium.org/924253002/diff/1/native_client_sdk/src/build_...
native_client_sdk/src/build_tools/build_sdk.py:537: out_dir, force_arm_gcc=True,
gyp_defines=None):
force_arm_gcc is never used...?