Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: sky/tests/lowlevel/query-selector.sky

Issue 924203002: Morph the APIs for Node, ParentNode, and Element closer to the specs (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tests/lowlevel/query-selector.sky
diff --git a/sky/tests/lowlevel/query-selector.sky b/sky/tests/lowlevel/query-selector.sky
index 64cf473d03810674f232d86e468cbf29750b56f4..502a798fc50ccbd0298f6cf5d0ba4733598a6cf2 100644
--- a/sky/tests/lowlevel/query-selector.sky
+++ b/sky/tests/lowlevel/query-selector.sky
@@ -36,13 +36,13 @@ main() {
test("should find elements by id", () {
expect(query("#id5"), isNotNull);
- expect(query("#id5").id, equals("id5"));
+ expect(query("#id5").getAttribute("id"), equals("id5"));
expect(query("#id5").classList.toString(), equals("class5"));
// FIXME(sky): Do we still want to allow multiple id stuff like this?
expect(queryAll("#id5").length, equals(2));
expect(queryAll("#id5").item(0), equals(query("#id5")));
expect(queryAll("#id5").item(1), isNot(equals(query("#id5"))));
- expect(queryAll("#id5").item(1).id, equals("id5"));
+ expect(queryAll("#id5").item(1).getAttribute("id"), equals("id5"));
});
test("should find elements by tag name", () {
@@ -55,7 +55,7 @@ main() {
test("should find an element by compound selector", () {
expect(query("tag-name-6.class6#id6"), isNotNull);
- expect(query("tag-name-6.class6#id6").id, equals("id6"));
+ expect(query("tag-name-6.class6#id6").getAttribute("id"), equals("id6"));
expect(query("tag-name-6.class6#id6").classList.toString(), equals("class6"));
expect(query("tag-name-6.class6#id6").tagName, equals("tag-name-6"));
});
@@ -63,21 +63,21 @@ main() {
test("should find all elements by compound selector", () {
expect(queryAll("tag-name-3.class7"), isNotNull);
expect(queryAll("tag-name-3.class7").length, equals(3));
- expect(queryAll("tag-name-3.class7").item(0).id, equals("tag1"));
- expect(queryAll("tag-name-3.class7").item(1).id, equals("tag2"));
+ expect(queryAll("tag-name-3.class7").item(0).getAttribute("id"), equals("tag1"));
+ expect(queryAll("tag-name-3.class7").item(1).getAttribute("id"), equals("tag2"));
});
test("should find all elements by attribute presence selector", () {
expect(queryAll("[testAttr]"), isNotNull);
expect(queryAll("[testAttr]").length, equals(2));
- expect(queryAll("[testAttr]").item(0).id, equals("id5"));
- expect(queryAll("[testAttr]").item(1).id, equals("id6"));
+ expect(queryAll("[testAttr]").item(0).getAttribute("id"), equals("id5"));
+ expect(queryAll("[testAttr]").item(1).getAttribute("id"), equals("id6"));
});
test("should find all elements by attribute value selector", () {
expect(queryAll("[testAttr='the value']"), isNotNull);
expect(queryAll("[testAttr='the value']").length, equals(1));
- expect(queryAll("[testAttr='the value']").item(0).id, equals("id6"));
+ expect(queryAll("[testAttr='the value']").item(0).getAttribute("id"), equals("id6"));
});
}
</script>

Powered by Google App Engine
This is Rietveld 408576698