sky/engine/tonic/dart_wrappable.cc - Issue 924203002: Morph the APIs for Node, ParentNode, and Element closer to the specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/tonic/dart_wrappable.cc

Issue 924203002: Morph the APIs for Node, ParentNode, and Element closer to the specs (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/tonic/dart_wrappable.cc

diff --git a/sky/engine/tonic/dart_wrappable.cc b/sky/engine/tonic/dart_wrappable.cc

index 6c7e3a15267fff3b4a7c22cbbdb5dafe79cffc24..1bf69d4cf5b023ba6101340539b1f5c3b40edcde 100644

--- a/sky/engine/tonic/dart_wrappable.cc

+++ b/sky/engine/tonic/dart_wrappable.cc

@@ -50,9 +50,9 @@ void DartWrappable::FinalizeDartWrapper(void* isolate_callback_data,

}

DartWrappable* DartConverterWrappable::FromDart(Dart_Handle handle) {

- intptr_t* peer = 0;

+ intptr_t peer = 0;

Dart_Handle result =

- Dart_GetNativeInstanceField(handle, DartWrappable::kPeerIndex, peer);

+ Dart_GetNativeInstanceField(handle, DartWrappable::kPeerIndex, &peer);

if (Dart_IsError(result))

return nullptr;

return reinterpret_cast<DartWrappable*>(peer);