Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: sky/engine/tonic/dart_converter.h

Issue 924203002: Morph the APIs for Node, ParentNode, and Element closer to the specs (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/tonic/dart_converter.h
diff --git a/sky/engine/tonic/dart_converter.h b/sky/engine/tonic/dart_converter.h
index 381af62d658ed695dffe2463b097070723c7eac5..2982589da56a95b3703c248bfb7d12825e1b16a8 100644
--- a/sky/engine/tonic/dart_converter.h
+++ b/sky/engine/tonic/dart_converter.h
@@ -248,9 +248,10 @@ struct DartConverter<Vector<T>> {
Dart_ListLength(handle, &length);
result.reserveCapacity(length);
for (intptr_t i = 0; i < length; ++i) {
- Dart_Handle element = Dart_ListGetAt(handle, i);
- DCHECK(!Dart_IsError(element));
- result.append(DartConverter<T>::FromDart(element));
+ Dart_Handle item = Dart_ListGetAt(handle, i);
+ DCHECK(!Dart_IsError(item));
+ DCHECK(item);
+ result.append(DartConverter<T>::FromDart(item));
}
return result;
}

Powered by Google App Engine
This is Rietveld 408576698