Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: sky/engine/core/dom/Element.h

Issue 924203002: Morph the APIs for Node, ParentNode, and Element closer to the specs (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/Element.h
diff --git a/sky/engine/core/dom/Element.h b/sky/engine/core/dom/Element.h
index 4b046b80b0047a8769b49a6b83c17b593d533a58..fbfe3298813c430319c29d7012eaab7957d0288e 100644
--- a/sky/engine/core/dom/Element.h
+++ b/sky/engine/core/dom/Element.h
@@ -76,6 +76,9 @@ public:
bool hasAttribute(const AtomicString& name) const;
const AtomicString& getAttribute(const AtomicString& name) const;
void setAttribute(const AtomicString& name, const AtomicString& value, ExceptionState&);
+ void setAttribute(const AtomicString& name, ExceptionState& es) {
esprehn 2015/02/13 23:53:48 default this to null in the idl instead?
abarth-chromium 2015/02/13 23:59:45 I don't think this function is ever called but the
+ setAttribute(name, String(), es);
+ }
void removeAttribute(const AtomicString& name);
void removeAttribute(const QualifiedName&);

Powered by Google App Engine
This is Rietveld 408576698