Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: sky/engine/bindings/scripts/dart_types.py

Issue 924203002: Morph the APIs for Node, ParentNode, and Element closer to the specs (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | sky/engine/core/dom/ContainerNode.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/scripts/dart_types.py
diff --git a/sky/engine/bindings/scripts/dart_types.py b/sky/engine/bindings/scripts/dart_types.py
index caaf17a47977afe573640f127aca17ab63b213a7..ccc4509ee2d7fdadd6845785e5dea4e822452936 100644
--- a/sky/engine/bindings/scripts/dart_types.py
+++ b/sky/engine/bindings/scripts/dart_types.py
@@ -413,21 +413,10 @@ def dart_value_to_cpp_value_array_or_sequence(native_array_element_type, variabl
# and is used to provide a human-readable exception message
if index is None:
index = 0 # special case, meaning "setter"
-# else:
-# index += 1 # human-readable index
- if (native_array_element_type.is_interface_type):
- this_cpp_type = None
- ref_ptr_type = 'RefPtr'
- # FIXME(vsm): We're not using ref_ptr_type....
- expression_format = '{variable_name} = DartConverter<Vector<{native_array_element_type}>>::FromArguments(args, {index}, exception)'
- add_includes_for_type(native_array_element_type)
- else:
- ref_ptr_type = None
- this_cpp_type = native_array_element_type.cpp_type
- expression_format = '{variable_name} = DartConverter<Vector<{cpp_type}>>::FromArguments(args, {index}, exception)'
-
+ this_cpp_type = native_array_element_type.cpp_type
+ expression_format = '{variable_name} = DartConverter<Vector<{cpp_type}>>::FromArguments(args, {index}, exception)'
expression = expression_format.format(native_array_element_type=native_array_element_type.name,
- cpp_type=this_cpp_type, index=index, ref_ptr_type=ref_ptr_type,
+ cpp_type=this_cpp_type, index=index,
variable_name=variable_name)
return expression
« no previous file with comments | « no previous file | sky/engine/core/core.gni » ('j') | sky/engine/core/dom/ContainerNode.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698