Chromium Code Reviews

Issue 924193006: Set unregistered handles to NULL in BatteryStatusObserver::Stop (Closed)

Created:
5 years, 10 months ago by marcing
Modified:
5 years, 10 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set unregistered handles to NULL in BatteryStatusObserver::Stop BatteryStatusObserver::Stop can be called twice from BatteryStatusService::Shutdown, so power_handle_ and batter_change_handle_ should be set to NULL on the first call, otherwise the second call will pass invalid handles to UnregisterNotification. Committed: https://crrev.com/5db108fb20e9159956cff0af45a505ca52bb80d6 Cr-Commit-Position: refs/heads/master@{#317321}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+6 lines, -2 lines)
M device/battery/battery_status_manager_win.cc View 1 chunk +6 lines, -2 lines 0 comments

Messages

Total messages: 7 (2 generated)
marcing
5 years, 10 months ago (2015-02-20 12:48:25 UTC) #2
timvolodine
lgtm thanks!
5 years, 10 months ago (2015-02-20 13:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924193006/1
5 years, 10 months ago (2015-02-20 14:24:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:28:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 15:28:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5db108fb20e9159956cff0af45a505ca52bb80d6
Cr-Commit-Position: refs/heads/master@{#317321}

Powered by Google App Engine