Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 924193005: Add keyboard navigation to the custom launcher page on app list start page. (Closed)

Created:
5 years, 10 months ago by Matt Giuca
Modified:
5 years, 10 months ago
Reviewers:
tapted, calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add keyboard navigation to the custom launcher page on app list start page. This CL makes it possible to navigate to the custom launcher page from the start page using the keyboard. Patch written by calamity@chromium.org. Original code review at https://codereview.chromium.org/941213003/. BUG=458884 R=mgiuca@chromium.org Committed: https://crrev.com/7b42856f352f4a8eb07682d082fb8d553bba81b8 Cr-Commit-Position: refs/heads/master@{#317305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -9 lines) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M ui/app_list/app_list_model.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/app_list/views/start_page_view.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ui/app_list/views/start_page_view.cc View 9 chunks +85 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Matt Giuca
Alternatively, fix the conflict in https://codereview.chromium.org/941213003/ and commit that.
5 years, 10 months ago (2015-02-20 12:06:49 UTC) #2
tapted
lgtm
5 years, 10 months ago (2015-02-20 12:16:26 UTC) #4
Matt Giuca
Oh hi Trent. Thanks!
5 years, 10 months ago (2015-02-20 12:17:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924193005/1
5 years, 10 months ago (2015-02-20 12:18:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 13:07:47 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 13:08:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b42856f352f4a8eb07682d082fb8d553bba81b8
Cr-Commit-Position: refs/heads/master@{#317305}

Powered by Google App Engine
This is Rietveld 408576698