Issue 924163004: Specs: (reverts part of recent checkin) Make appendChild, prependChild, and setChild not return the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 924163004: Specs: (reverts part of recent checkin) Make appendChild, prependChild, and setChild not return the… (Closed)

Created:
5 years, 10 months ago by Hixie

Modified:
5 years, 10 months ago

Reviewers:

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Specs: (reverts part of recent checkin) Make appendChild, prependChild, and setChild not return the child, since that can improve perf (especially if they're actually implemented natively) Committed: https://chromium.googlesource.com/external/mojo/+/df24934d0d12c32772d253054b50657b1de85bb0

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	sky/specs/elements.md	View		3 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 1 (0 generated)

Hixie

5 years, 10 months ago (2015-02-13 23:48:27 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
df24934d0d12c32772d253054b50657b1de85bb0.