Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 924143005: cc: Stop passing the occlusion explicitly to UpdateTiles. (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Stop passing the occlusion explicitly to UpdateTiles. The occlusion is a draw property, the layer can access it from there like other draw properties. Cleanup CL since moving occlusion to draw properties. R=enne BUG=446751 Committed: https://crrev.com/83c3d4a861627992abf7a42c7c02163f416add23 Cr-Commit-Position: refs/heads/master@{#316355}

Patch Set 1 #

Patch Set 2 : passocclusion: perftests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -35 lines) Patch
M cc/layers/picture_image_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M cc/resources/tile_manager_perftest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
danakj
5 years, 10 months ago (2015-02-14 00:32:31 UTC) #1
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-14 00:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924143005/1
5 years, 10 months ago (2015-02-14 00:33:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/8357) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 10 months ago (2015-02-14 00:40:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924143005/20001
5 years, 10 months ago (2015-02-14 00:53:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-14 01:43:07 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 01:44:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83c3d4a861627992abf7a42c7c02163f416add23
Cr-Commit-Position: refs/heads/master@{#316355}

Powered by Google App Engine
This is Rietveld 408576698