Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/perf/page_sets/key_silk_cases.py

Issue 924133002: [Telemetry] Add run_no_page_interactions options to key_silk_cases page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/rasterize_and_record_micro.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/key_silk_cases.py
diff --git a/tools/perf/page_sets/key_silk_cases.py b/tools/perf/page_sets/key_silk_cases.py
index 3b737ddc9b775b143122c6f5797e796f428b8553..dee9ef8b16b7077c739bed07ab63ae7394a932e2 100644
--- a/tools/perf/page_sets/key_silk_cases.py
+++ b/tools/perf/page_sets/key_silk_cases.py
@@ -7,17 +7,34 @@ from telemetry.page import page_set as page_set_module
class KeySilkCasesPage(page_module.Page):
- def __init__(self, url, page_set):
+ def __init__(self, url, page_set, run_no_page_interactions):
+ """ Base class for all key silk cases pages.
+
+ Args:
+ run_no_page_interactions: whether the page will run any interactions after
+ navigate steps.
+ """
super(KeySilkCasesPage, self).__init__(
url=url, page_set=page_set, credentials_path = 'data/credentials.json')
self.user_agent_type = 'mobile'
self.archive_data_file = 'data/key_silk_cases.json'
+ self._run_no_page_interactions = run_no_page_interactions
def RunNavigateSteps(self, action_runner):
super(KeySilkCasesPage, self).RunNavigateSteps(action_runner)
action_runner.Wait(2)
def RunPageInteractions(self, action_runner):
+ # If a key silk case page wants to customize it actions, it should
+ # overrides the PerformPageInteractions method instead of this method.
+ if self._run_no_page_interactions:
+ return
+ self.PerformPageInteractions(action_runner)
+
+ def PerformPageInteractions(self, action_runner):
+ """ Perform interactions on page after navigate steps.
+ Override this to define custom actions to be run after navigate steps.
+ """
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollPage()
@@ -28,12 +45,12 @@ class Page1(KeySilkCasesPage):
""" Why: Infinite scroll. Brings out all of our perf issues. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page1, self).__init__(
url='http://groupcloned.com/test/plain/list-recycle-transform.html',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollElement(selector='#scrollable')
@@ -44,12 +61,12 @@ class Page2(KeySilkCasesPage):
""" Why: Brings out layer management bottlenecks. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page2, self).__init__(
url='http://groupcloned.com/test/plain/list-animation-simple.html',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(2)
@@ -60,13 +77,13 @@ class Page3(KeySilkCasesPage):
compositor scrolls.
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page3, self).__init__(
# pylint: disable=C0301
url='http://groupcloned.com/test/plain/sticky-using-webkit-backface-visibility.html',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollElement(selector='#container')
@@ -80,12 +97,12 @@ class Page4(KeySilkCasesPage):
storms happen.
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page4, self).__init__(
url='http://jsfiddle.net/3yDKh/15/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(3)
@@ -95,14 +112,14 @@ class Page5(KeySilkCasesPage):
Why: Card expansion with animated contents, using will-change on the card
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page5, self).__init__(
url='http://jsfiddle.net/jx5De/14/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
self.gpu_raster = True
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(4)
@@ -113,12 +130,12 @@ class Page6(KeySilkCasesPage):
margin-top and letting layout do the rest.
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page6, self).__init__(
url='http://jsfiddle.net/3yDKh/16/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(3)
@@ -130,12 +147,12 @@ class Page7(KeySilkCasesPage):
unnecessary repainting.
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page7, self).__init__(
url='http://jsfiddle.net/R8DX9/4/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(3)
@@ -147,12 +164,12 @@ class Page8(KeySilkCasesPage):
repainting.
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page8, self).__init__(
url='http://jsfiddle.net/rF9Gh/7/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(3)
@@ -163,14 +180,14 @@ class Page9(KeySilkCasesPage):
costly to rasterize.
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page9, self).__init__(
url='http://jsfiddle.net/TLXLu/3/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
self.gpu_raster = True
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(4)
@@ -181,14 +198,14 @@ class Page10(KeySilkCasesPage):
rasterize.
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page10, self).__init__(
url='http://jsfiddle.net/cKB9D/7/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
self.gpu_raster = True
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(4)
@@ -199,14 +216,14 @@ class Page11(KeySilkCasesPage):
software rasterization
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page11, self).__init__(
url='http://jsfiddle.net/vBQHH/11/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
self.gpu_raster = True
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(4)
@@ -214,12 +231,12 @@ class Page12(KeySilkCasesPage):
""" Why: Addressing paint storms during coordinated animations. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page12, self).__init__(
url='http://jsfiddle.net/ugkd4/10/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(5)
@@ -227,14 +244,14 @@ class Page13(KeySilkCasesPage):
""" Why: Mask transitions are common mobile use cases. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page13, self).__init__(
url='http://jsfiddle.net/xLuvC/1/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
self.gpu_raster = True
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(4)
@@ -242,14 +259,14 @@ class Page14(KeySilkCasesPage):
""" Why: Card expansions with images and text are pretty and common. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page14, self).__init__(
url='http://jsfiddle.net/bNp2h/3/show/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
self.gpu_raster = True
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(4)
@@ -257,21 +274,21 @@ class Page15(KeySilkCasesPage):
""" Why: Coordinated animations for expanding elements. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page15, self).__init__(
url='file://key_silk_cases/font_wipe.html',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
action_runner.Wait(5)
class Page16(KeySilkCasesPage):
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page16, self).__init__(
url='file://key_silk_cases/inbox_app.html?swipe_to_dismiss',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def SwipeToDismiss(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
@@ -282,18 +299,18 @@ class Page16(KeySilkCasesPage):
element_function='document.getElementsByClassName("message")[2]')
interaction.End()
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
self.SwipeToDismiss(action_runner)
class Page17(KeySilkCasesPage):
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page17, self).__init__(
url='file://key_silk_cases/inbox_app.html?stress_hidey_bars',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
self.StressHideyBars(action_runner)
def StressHideyBars(self, action_runner):
@@ -316,12 +333,12 @@ class Page17(KeySilkCasesPage):
class Page18(KeySilkCasesPage):
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page18, self).__init__(
url='file://key_silk_cases/inbox_app.html?toggle_drawer',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
for _ in xrange(6):
self.ToggleDrawer(action_runner)
@@ -335,10 +352,10 @@ class Page18(KeySilkCasesPage):
class Page19(KeySilkCasesPage):
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page19, self).__init__(
url='file://key_silk_cases/inbox_app.html?slide_drawer',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def ToggleDrawer(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
@@ -358,7 +375,7 @@ class Page19(KeySilkCasesPage):
action_runner.Wait(2)
self.ToggleDrawer(action_runner)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
self.SlideDrawer(action_runner)
def SlideDrawer(self, action_runner):
@@ -377,12 +394,12 @@ class Page20(KeySilkCasesPage):
""" Why: Shadow DOM infinite scrolling. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page20, self).__init__(
url='file://key_silk_cases/infinite_scrolling.html',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollElement(
@@ -411,7 +428,7 @@ class GwsExpansionPage(KeySilkCasesPage):
action_runner.ExecuteJavaScript(
"document.getElementById('%s').scrollIntoView()" % card_id)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
self.ExpandKnowledgeCard(action_runner)
@@ -419,10 +436,10 @@ class GwsGoogleExpansion(GwsExpansionPage):
""" Why: Animating height of a complex content card is common. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(GwsGoogleExpansion, self).__init__(
url='http://www.google.com/#q=google',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def RunNavigateSteps(self, action_runner):
self.NavigateWait(action_runner)
@@ -433,10 +450,10 @@ class GwsBoogieExpansion(GwsExpansionPage):
""" Why: Same case as Google expansion but text-heavy rather than image. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(GwsBoogieExpansion, self).__init__(
url='https://www.google.com/search?hl=en&q=define%3Aboogie',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def RunNavigateSteps(self, action_runner):
self.NavigateWait(action_runner)
@@ -445,10 +462,10 @@ class GwsBoogieExpansion(GwsExpansionPage):
class Page22(KeySilkCasesPage):
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page22, self).__init__(
url='http://plus.google.com/app/basic/stream',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
self.credentials = 'google'
@@ -458,7 +475,7 @@ class Page22(KeySilkCasesPage):
'document.getElementsByClassName("fHa").length > 0')
action_runner.Wait(2)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollElement(selector='#mainContent')
@@ -472,12 +489,12 @@ class Page23(KeySilkCasesPage):
triggering JS and recalc slowness
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page23, self).__init__(
url='http://jsbin.com/UVIgUTa/38/quiet',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollPage(
@@ -496,10 +513,10 @@ class Page24(KeySilkCasesPage):
Why: Google News: this iOS version is slower than accelerated scrolling
"""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page24, self).__init__(
url='http://mobile-news.sandbox.google.com/news/pt0?scroll',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def RunNavigateSteps(self, action_runner):
super(Page24, self).RunNavigateSteps(action_runner)
@@ -507,7 +524,7 @@ class Page24(KeySilkCasesPage):
'document.getElementById(":h") != null')
action_runner.Wait(1)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollElement(
@@ -519,10 +536,10 @@ class Page24(KeySilkCasesPage):
class Page25(KeySilkCasesPage):
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page25, self).__init__(
url='http://mobile-news.sandbox.google.com/news/pt0?swipe',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def RunNavigateSteps(self, action_runner):
super(Page25, self).RunNavigateSteps(action_runner)
@@ -530,7 +547,7 @@ class Page25(KeySilkCasesPage):
'document.getElementById(":h") != null')
action_runner.Wait(1)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'SwipeAction', is_smooth=True)
action_runner.SwipeElement(
@@ -546,10 +563,10 @@ class Page26(KeySilkCasesPage):
""" Why: famo.us twitter demo """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(Page26, self).__init__(
url='http://s.codepen.io/befamous/fullpage/pFsqb?scroll',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def RunNavigateSteps(self, action_runner):
super(Page26, self).RunNavigateSteps(action_runner)
@@ -557,7 +574,7 @@ class Page26(KeySilkCasesPage):
'document.getElementsByClassName("tweet").length > 0')
action_runner.Wait(1)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginGestureInteraction(
'ScrollAction', is_smooth=True)
action_runner.ScrollPage(distance=5000)
@@ -568,10 +585,10 @@ class SVGIconRaster(KeySilkCasesPage):
""" Why: Mutating SVG icons; these paint storm and paint slowly. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(SVGIconRaster, self).__init__(
url='http://wiltzius.github.io/shape-shifter/',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def RunNavigateSteps(self, action_runner):
super(SVGIconRaster, self).RunNavigateSteps(action_runner)
@@ -579,7 +596,7 @@ class SVGIconRaster(KeySilkCasesPage):
'loaded = true')
action_runner.Wait(1)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
for i in xrange(9):
button_func = ('document.getElementById("demo").$.'
'buttons.children[%d]') % i
@@ -594,10 +611,10 @@ class UpdateHistoryState(KeySilkCasesPage):
""" Why: Modern apps often update history state, which currently is janky."""
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(UpdateHistoryState, self).__init__(
url='file://key_silk_cases/pushState.html',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
def RunNavigateSteps(self, action_runner):
super(UpdateHistoryState, self).RunNavigateSteps(action_runner)
@@ -609,7 +626,7 @@ class UpdateHistoryState(KeySilkCasesPage):
action_runner.WaitForJavaScriptCondition(
'window.__history_state_loaded == true;')
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginInteraction('animation_interaction',
is_smooth=True)
action_runner.Wait(5) # JS runs the animation continuously on the page
@@ -620,12 +637,12 @@ class SilkFinance(KeySilkCasesPage):
""" Why: Some effects repaint the page, possibly including plenty of text. """
- def __init__(self, page_set):
+ def __init__(self, page_set, run_no_page_interactions):
super(SilkFinance, self).__init__(
url='file://key_silk_cases/silk_finance.html',
- page_set=page_set)
+ page_set=page_set, run_no_page_interactions=run_no_page_interactions)
- def RunPageInteractions(self, action_runner):
+ def PerformPageInteractions(self, action_runner):
interaction = action_runner.BeginInteraction('animation_interaction',
is_smooth=True)
action_runner.Wait(10) # animation runs automatically
@@ -636,41 +653,47 @@ class KeySilkCasesPageSet(page_set_module.PageSet):
""" Pages hand-picked for project Silk. """
- def __init__(self):
+ def __init__(self, run_no_page_interactions=False):
super(KeySilkCasesPageSet, self).__init__(
user_agent_type='mobile',
archive_data_file='data/key_silk_cases.json',
bucket=page_set_module.PARTNER_BUCKET)
- self.AddUserStory(Page1(self))
- self.AddUserStory(Page2(self))
- self.AddUserStory(Page3(self))
- self.AddUserStory(Page4(self))
- self.AddUserStory(Page5(self))
- self.AddUserStory(Page6(self))
- self.AddUserStory(Page7(self))
- self.AddUserStory(Page8(self))
- self.AddUserStory(Page9(self))
- self.AddUserStory(Page10(self))
- self.AddUserStory(Page11(self))
- self.AddUserStory(Page12(self))
- self.AddUserStory(Page13(self))
- self.AddUserStory(Page14(self))
- self.AddUserStory(Page15(self))
- self.AddUserStory(Page16(self))
- self.AddUserStory(Page17(self))
- self.AddUserStory(Page18(self))
+ self.AddUserStory(Page1(self, run_no_page_interactions))
+ self.AddUserStory(Page2(self, run_no_page_interactions))
+ self.AddUserStory(Page3(self, run_no_page_interactions))
+ self.AddUserStory(Page4(self, run_no_page_interactions))
+ self.AddUserStory(Page5(self, run_no_page_interactions))
+ self.AddUserStory(Page6(self, run_no_page_interactions))
+ self.AddUserStory(Page7(self, run_no_page_interactions))
+ self.AddUserStory(Page8(self, run_no_page_interactions))
+ self.AddUserStory(Page9(self, run_no_page_interactions))
+ self.AddUserStory(Page10(self, run_no_page_interactions))
+ self.AddUserStory(Page11(self, run_no_page_interactions))
+ self.AddUserStory(Page12(self, run_no_page_interactions))
+ self.AddUserStory(Page13(self, run_no_page_interactions))
+ self.AddUserStory(Page14(self, run_no_page_interactions))
+ self.AddUserStory(Page15(self, run_no_page_interactions))
+ self.AddUserStory(Page16(self, run_no_page_interactions))
+ self.AddUserStory(Page17(self, run_no_page_interactions))
+ self.AddUserStory(Page18(self, run_no_page_interactions))
# Missing frames during tap interaction; crbug.com/446332
- # self.AddUserStory(Page19(self))
- self.AddUserStory(Page20(self))
- self.AddUserStory(GwsGoogleExpansion(self))
- self.AddUserStory(GwsBoogieExpansion(self))
+ # self.AddUserStory(Page19(self, run_no_page_interactions))
+ self.AddUserStory(Page20(self, run_no_page_interactions))
+ self.AddUserStory(GwsGoogleExpansion(self, run_no_page_interactions))
+ self.AddUserStory(GwsBoogieExpansion(self, run_no_page_interactions))
# Times out on Windows; crbug.com/338838
- # self.AddUserStory(Page22(self))
- self.AddUserStory(Page23(self))
- self.AddUserStory(Page24(self))
- self.AddUserStory(Page25(self))
- self.AddUserStory(Page26(self))
- self.AddUserStory(SVGIconRaster(self))
- self.AddUserStory(UpdateHistoryState(self))
- self.AddUserStory(SilkFinance(self))
+ # self.AddUserStory(Page22(self, run_no_page_interactions))
+ self.AddUserStory(Page23(self, run_no_page_interactions))
+ self.AddUserStory(Page24(self, run_no_page_interactions))
+ self.AddUserStory(Page25(self, run_no_page_interactions))
+ self.AddUserStory(Page26(self, run_no_page_interactions))
+ self.AddUserStory(SVGIconRaster(self, run_no_page_interactions))
+ self.AddUserStory(UpdateHistoryState(self, run_no_page_interactions))
+ self.AddUserStory(SilkFinance(self, run_no_page_interactions))
+
+ for page in self:
+ assert (page.__class__.RunPageInteractions ==
+ KeySilkCasesPage.RunPageInteractions), (
+ 'Pages in this page set must not override KeySilkCasesPage\' '
+ 'RunPageInteractions method.')
« no previous file with comments | « tools/perf/benchmarks/rasterize_and_record_micro.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698