Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 924133002: [Telemetry] Add run_no_page_interactions options to key_silk_cases page. (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add run_no_page_interactions options to key_silk_cases page. This is to prepare for switching rasterize_and_micro_record's action_name_to_run from empty string to 'RunPageInteractions'. BUG=418375 Committed: https://crrev.com/76b7ef991fc2e252c89e935fd56d6bc3b7d621af Cr-Commit-Position: refs/heads/master@{#316315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -122 lines) Patch
M tools/perf/benchmarks/rasterize_and_record_micro.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 39 chunks +144 lines, -121 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 10 months ago (2015-02-13 21:39:55 UTC) #2
sullivan
lgtm
5 years, 10 months ago (2015-02-13 21:47:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924133002/1
5 years, 10 months ago (2015-02-13 21:50:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 23:08:15 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 23:09:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76b7ef991fc2e252c89e935fd56d6bc3b7d621af
Cr-Commit-Position: refs/heads/master@{#316315}

Powered by Google App Engine
This is Rietveld 408576698