Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 924123002: ES6 Classes: Remove tracking of super construct calls. (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6 Classes: Remove tracking of super construct calls. With the new ES6 semantics super construct calls are only valid in a constructor in a derived class. This is something that is statically known and we report early SyntaxError in case it occurs. We therefore do not need to track this any more. BUG=v8:3330 LOG=N R=dslomov@chromium.org, adamk Committed: https://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93 Cr-Commit-Position: refs/heads/master@{#26644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -49 lines) Patch
M src/ast.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parser.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/preparser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/scopes.h View 4 chunks +0 lines, -16 lines 0 comments Download
M src/scopes.cc View 5 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL The test for this was removed when I made this case a SyntaxError.
5 years, 10 months ago (2015-02-13 21:38:00 UTC) #1
Dmitry Lomov (no reviews)
lgtm! Less kode FTW
5 years, 10 months ago (2015-02-13 21:44:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924123002/1
5 years, 10 months ago (2015-02-13 21:55:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 22:26:25 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 22:26:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0c2c2b32c551d927c65d83d479226892291ce93
Cr-Commit-Position: refs/heads/master@{#26644}

Powered by Google App Engine
This is Rietveld 408576698