Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 924093002: Removing presubmit from annotator. (Closed)

Created:
5 years, 10 months ago by bradn
Modified:
5 years, 10 months ago
Reviewers:
Sam Clegg
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Dropping presubmit from annotator. Now doing the presubmit using recipes to mesh better with the buildbot. BUG=None TEST=None R=sbc@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/cbec56bcaf86b2efb952af690b69dea8a7881696

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M build_tools/buildbot_selector.sh View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M build_tools/update_mirror.py View 1 2 3 4 5 6 7 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bradn
5 years, 10 months ago (2015-02-14 00:00:40 UTC) #1
Sam Clegg
lgtm
5 years, 10 months ago (2015-02-14 01:14:15 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 10 months ago (2015-02-14 03:02:56 UTC) #7
bradn
5 years, 10 months ago (2015-02-14 03:03:24 UTC) #8
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) manually as
cbec56bcaf86b2efb952af690b69dea8a7881696 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698