Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 924083004: Shorten Closure template notation from Array.<*> to Array<*> in cvox. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shorten Closure template notation from Array.<*> to Array<*> in cvox. These are equivalent syntaxes, the latter is just newer and shorter and more closely resembles C++/Java. R=dmazzoni@chromium.org BUG=none Committed: https://crrev.com/6daa58f92bff772a4476f761ef4c640bf90a2605 Cr-Commit-Position: refs/heads/master@{#316538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -738 lines) Patch
M chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/braille_key_types.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/braille_table.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/liblouis.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/pan_strategy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/externs.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/injected_script_loader.js View 2 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/key_map.js View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/mathmaps/math_map.js View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/active_indicator.js View 7 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js View 22 chunks +45 lines, -45 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api_implementation.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/externs.js View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/history.js View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/keyboard_handler.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_history.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_shifter.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_speaker.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/script_installer.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/node_search_widget.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/search_widget.js View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_event_detail.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/messages/msgs.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/aria_util.js View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/aural_style_util.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/braille_util.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 24 chunks +38 lines, -38 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chromevox.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chromevox_json.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/composite_tts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/content_editable_extractor.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/description_util.js View 11 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/dom_predicates.js View 30 chunks +30 lines, -30 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/dom_util.js View 11 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/find_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/interframe.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/key_sequence.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/key_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/math_semantic_attr.js View 64 chunks +87 lines, -87 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/math_semantic_tree.js View 35 chunks +60 lines, -60 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/math_semantic_util.js View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/math_util.js View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/memoize.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/nav_description.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/nav_math_description.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/node_state.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/page_selection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/selection_util.js View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/spannable.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/traverse_content.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/traverse_math.js View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/traverse_table.js View 8 chunks +19 lines, -22 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/traverse_util.js View 15 chunks +37 lines, -37 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/extensions/searchvox/search_tools.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/extension_bridge.js View 3 chunks +34 lines, -36 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/host.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/mathjax.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/testing/tts.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/base_rule_store.js View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/math_simple_store.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/math_store.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/mathml_store_util.js View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/speech_rule.js View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/speech_rule_engine.js View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/speech_rule_evaluator.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/speech_rule_functions.js View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/speech_rule_store.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/speech_rules/store_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/assert_additions.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/tester.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/abstract_shifter.js View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/abstract_walker.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/table_shifter.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/walkers/table_walker.js View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/third_party/chromevox/chromevox/injected/mathjax.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/chromevox/third_party/closure-library/closure/goog/asserts/asserts.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/third_party/chromevox/third_party/closure-library/closure/goog/base.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/third_party/chromevox/third_party/closure-library/closure/goog/i18n/messageformat.js View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/third_party/chromevox/third_party/closure-library/closure/goog/object/object.js View 20 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Dan Beam
split off these changes because there were cvox-related try job failures. let's see if they ...
5 years, 10 months ago (2015-02-14 02:47:27 UTC) #1
dmazzoni
Fine with me, but Peter & David are the primary owners so I'll make sure ...
5 years, 10 months ago (2015-02-14 07:08:05 UTC) #3
Peter Lundblad
lgtm Hi, Nice! Would you mind running this over our .extjs and .unitjs test files ...
5 years, 10 months ago (2015-02-16 16:34:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924083004/1
5 years, 10 months ago (2015-02-17 06:45:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 06:49:56 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6daa58f92bff772a4476f761ef4c640bf90a2605 Cr-Commit-Position: refs/heads/master@{#316538}
5 years, 10 months ago (2015-02-17 06:51:08 UTC) #8
Dan Beam
On 2015/02/16 16:34:48, Peter Lundblad wrote: > lgtm > > Hi, > > Nice! Would ...
5 years, 10 months ago (2015-02-17 07:00:34 UTC) #9
Peter Lundblad
5 years, 10 months ago (2015-02-17 10:12:26 UTC) #10
Message was sent while issue was closed.
dbeam@chromium.org writes:
> On 2015/02/16 16:34:48, Peter Lundblad wrote:
> > lgtm
> 
> > Hi,
> 
> > Nice!  Would you mind running this over our .extjs and .unitjs test files  
> > as
> > well? We don't (currently) compile these and there could very well be  
> > jsdoc
> > errors in those files. Still it'd be nice for consistency.  Sending lgtm  
> > in
> case
> > you'd rather do that in a separate cl.
> 
> will run on .extjs and .unitjs soon.  any reason why these aren't .js?

Yes, they are translated to C++, similar to the webui and js unit tests and
the gyp rules are selected based on the extension.

//Peter

> https://codereview.chromium.org/924083004/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698