chrome/chrome_common.gypi - Issue 924063003: [Favicon] Adding FallbackIconUrlParser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 924063003: [Favicon] Adding FallbackIconUrlParser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync, to include the fix from https://codereview.chromium.org/971623003 . Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 0ecfd4f412ee8c489ef63a7b211a8cc262cb6f84..6a80c5bf696424e67df2aabfe72061af27dbb32e 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -51,6 +51,8 @@

'common/custom_handlers/protocol_handler.cc',

'common/custom_handlers/protocol_handler.h',

'common/descriptors_android.h',

+ 'common/favicon/fallback_icon_url_parser.cc',

+ 'common/favicon/fallback_icon_url_parser.h',

'common/favicon/favicon_url_parser.cc',

'common/favicon/favicon_url_parser.h',

'common/icon_with_badge_image_source.cc',

@@ -317,6 +319,7 @@

'<(DEPTH)/crypto/crypto.gyp:crypto',

'<(DEPTH)/net/net.gyp:net',

'<(DEPTH)/skia/skia.gyp:skia',

+ '<(DEPTH)/skia/skia.gyp:skia_library',

'<(DEPTH)/third_party/icu/icu.gyp:icui18n',

'<(DEPTH)/third_party/icu/icu.gyp:icuuc',

'<(DEPTH)/third_party/libxml/libxml.gyp:libxml',

« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »