Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/common/favicon/fallback_icon_url_parser_unittest.cc

Issue 924063003: [Favicon] Adding FallbackIconUrlParser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync, to include the fix from https://codereview.chromium.org/971623003 . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/favicon/fallback_icon_url_parser.cc ('k') | skia/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/favicon/fallback_icon_url_parser.h"
6
7 #include "base/memory/scoped_ptr.h"
8 #include "components/favicon_base/fallback_icon_style.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "third_party/skia/include/core/SkColor.h"
11 #include "ui/gfx/favicon_size.h"
12 #include "url/gurl.h"
13
14 using chrome::ParsedFallbackIconPath;
15 using favicon_base::FallbackIconStyle;
16
17 namespace chrome {
18
19 namespace {
20
21 // Default values for FallbackIconStyle, from
22 // /components/favicon_base/fallback_icon_style.h
23 SkColor kDefaultBackgroundColor = SkColorSetRGB(0x80, 0x80, 0x80);
24 SkColor kDefaultTextColorDark = SK_ColorBLACK;
25 SkColor kDefaultTextColorLight = SK_ColorWHITE;
26 double kDefaultFontSizeRatio = 0.8;
27 double kDefaultRoundness = 0.125; // 1 / 8.
28
29 const char kTestUrlStr[] = "https://www.google.ca/imghp?hl=en&tab=wi";
30
31 } // namespace
32
33 class FallbackIconUrlParserTest : public testing::Test {
34 public:
35 FallbackIconUrlParserTest() {
36 }
37
38 bool ParseSpecs(const std::string& specs_str,
39 int *size,
40 favicon_base::FallbackIconStyle* style) {
41 return ParsedFallbackIconPath::ParseSpecs(specs_str, size, style);
42 }
43
44 bool ParseColor(const std::string& color_str, SkColor* color) {
45 int size_dummy;
46 favicon_base::FallbackIconStyle style;
47 std::string spec_str = "16," + color_str + ",,,";
48 if (!ParseSpecs(spec_str, &size_dummy, &style))
49 return false;
50 *color = style.background_color;
51 return true;
52 }
53
54 private:
55 DISALLOW_COPY_AND_ASSIGN(FallbackIconUrlParserTest);
56 };
57
58 TEST_F(FallbackIconUrlParserTest, ParseColorSuccess) {
59 SkColor c;
60 EXPECT_TRUE(ParseColor("#01aBf0f4", &c));
61 EXPECT_EQ(SkColorSetARGB(0x01, 0xAB, 0xF0, 0xF4), c);
62 EXPECT_TRUE(ParseColor("#01aBf0", &c));
63 EXPECT_EQ(SkColorSetRGB(0x01, 0xAB, 0xF0), c);
64 EXPECT_TRUE(ParseColor("#01a", &c));
65 EXPECT_EQ(SkColorSetRGB(0x00, 0x11, 0xAA), c);
66 EXPECT_TRUE(ParseColor("#000000", &c));
67 EXPECT_EQ(SkColorSetARGB(0xFF, 0x00, 0x00, 0x00), c);
68 EXPECT_TRUE(ParseColor("red", &c));
69 EXPECT_EQ(SkColorSetARGB(0xFF, 0xFF, 0x00, 0x00), c);
70 }
71
72 TEST_F(FallbackIconUrlParserTest, ParseColorFailure) {
73 const char* test_cases[] = {
74 "#00000",
75 "#000000000",
76 " #000000",
77 "#ABCDEFG",
78 "000000",
79 "#000000 ",
80 };
81 for (size_t i = 0; i < arraysize(test_cases); ++i) {
82 SkColor c;
83 EXPECT_FALSE(ParseColor(test_cases[i], &c))
84 << "test_cases[" << i << "]";
85 }
86 }
87
88 TEST_F(FallbackIconUrlParserTest, ParseSpecsEmpty) {
89 int size;
90 FallbackIconStyle style;
91 EXPECT_TRUE(ParseSpecs(",,,,", &size, &style));
92 EXPECT_EQ(16, size);
93 EXPECT_EQ(kDefaultBackgroundColor, style.background_color);
94 EXPECT_EQ(kDefaultTextColorLight, style.text_color);
95 EXPECT_EQ(kDefaultFontSizeRatio, style.font_size_ratio);
96 EXPECT_EQ(kDefaultRoundness, style.roundness);
97 }
98
99 TEST_F(FallbackIconUrlParserTest, ParseSpecsPartial) {
100 int size;
101 FallbackIconStyle style;
102 EXPECT_TRUE(ParseSpecs(",,#aCE,,0.1", &size, &style));
103 EXPECT_EQ(16, size);
104 EXPECT_EQ(kDefaultBackgroundColor, style.background_color);
105 EXPECT_EQ(SkColorSetRGB(0xAA, 0xCC, 0xEE), style.text_color);
106 EXPECT_EQ(kDefaultFontSizeRatio, style.font_size_ratio);
107 EXPECT_EQ(0.1, style.roundness);
108 }
109
110 TEST_F(FallbackIconUrlParserTest, ParseSpecsFull) {
111 int size;
112
113 {
114 FallbackIconStyle style;
115 EXPECT_TRUE(ParseSpecs("16,#000,#f01,0.75,0.25", &size, &style));
116 EXPECT_EQ(16, size);
117 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
118 EXPECT_EQ(SkColorSetRGB(0xff, 0x00, 0x11), style.text_color);
119 EXPECT_EQ(0.75, style.font_size_ratio);
120 EXPECT_EQ(0.25, style.roundness);
121 }
122
123 {
124 FallbackIconStyle style;
125 EXPECT_TRUE(ParseSpecs("48,black,#123456,0.5,0.3", &size, &style));
126 EXPECT_EQ(48, size);
127 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
128 EXPECT_EQ(SkColorSetRGB(0x12, 0x34, 0x56), style.text_color);
129 EXPECT_EQ(0.5, style.font_size_ratio);
130 EXPECT_EQ(0.3, style.roundness);
131 }
132
133 {
134 FallbackIconStyle style;
135 EXPECT_TRUE(ParseSpecs("1,#000,red,0,0", &size, &style));
136 EXPECT_EQ(1, size);
137 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
138 EXPECT_EQ(SkColorSetRGB(0xFF, 0x00, 0x00), style.text_color);
139 EXPECT_EQ(0, style.font_size_ratio);
140 EXPECT_EQ(0, style.roundness);
141 }
142 }
143
144 TEST_F(FallbackIconUrlParserTest, ParseSpecsDefaultTextColor) {
145 int size;
146
147 {
148 // Dark background -> Light text.
149 FallbackIconStyle style;
150 EXPECT_TRUE(ParseSpecs(",#000,,,", &size, &style));
151 EXPECT_EQ(kDefaultTextColorLight, style.text_color);
152 }
153
154 {
155 // Light background -> Dark text.
156 FallbackIconStyle style;
157 EXPECT_TRUE(ParseSpecs(",#fff,,,", &size, &style));
158 EXPECT_EQ(kDefaultTextColorDark, style.text_color);
159 }
160
161 {
162 // Light background -> Dark text, more params don't matter.
163 FallbackIconStyle style;
164 EXPECT_TRUE(ParseSpecs("107,#fff,,0.3,0.5", &size, &style));
165 EXPECT_EQ(kDefaultTextColorDark, style.text_color);
166 }
167 }
168
169 TEST_F(FallbackIconUrlParserTest, ParseSpecsFailure) {
170 const char* test_cases[] = {
171 // Need exactly 5 params.
172 "",
173 "16",
174 "16,black",
175 "16,black,#fff",
176 "16,black,#fff,0.75",
177 ",,,"
178 ",,,,,",
179 "16,black,#fff,0.75,0.25,junk",
180 // Don't allow any space.
181 "16,black,#fff, 0.75,0.25",
182 "16,black ,#fff,0.75,0.25",
183 "16,black,#fff,0.75,0.25 ",
184 // Adding junk text.
185 "16,black,#fff,0.75,0.25junk",
186 "junk,black,#fff,0.75,0.25",
187 "16,#junk,#fff,0.75,0.25",
188 "16,black,#junk,0.75,0.25",
189 "16,black,#fff,junk,0.25",
190 "16,black,#fff,0.75,junk",
191 // Out of bound.
192 "0,black,#fff,0.75,0.25", // size.
193 "4294967296,black,#fff,0.75,0.25", // size.
194 "-1,black,#fff,0.75,0.25", // size.
195 "16,black,#fff,-0.1,0.25", // font_size_ratio.
196 "16,black,#fff,1.1,0.25", // font_size_ratio.
197 "16,black,#fff,0.75,-0.1", // roundness.
198 "16,black,#fff,0.75,1.1", // roundness.
199 };
200 for (size_t i = 0; i < arraysize(test_cases); ++i) {
201 int size;
202 FallbackIconStyle style;
203 EXPECT_FALSE(ParseSpecs(test_cases[i], &size, &style))
204 << "test_cases[" << i << "]";
205
206 }
207 }
208
209 TEST_F(FallbackIconUrlParserTest, ParseFallbackIconPathSuccess) {
210 const std::string specs = "31,black,#fff,0.75,0.25";
211
212 // Everything populated.
213 {
214 chrome::ParsedFallbackIconPath parsed;
215 EXPECT_TRUE(parsed.Parse(specs + "/" + kTestUrlStr));
216 EXPECT_EQ(GURL(kTestUrlStr), parsed.url());
217 EXPECT_EQ(31, parsed.size_in_pixels());
218 const favicon_base::FallbackIconStyle& style = parsed.style();
219 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
220 EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color);
221 EXPECT_EQ(0.75, style.font_size_ratio);
222 EXPECT_EQ(0.25, style.roundness);
223 }
224
225 // Empty URL.
226 {
227 chrome::ParsedFallbackIconPath parsed;
228 EXPECT_TRUE(parsed.Parse(specs + "/"));
229 EXPECT_EQ(GURL(), parsed.url());
230 EXPECT_EQ(31, parsed.size_in_pixels());
231 const favicon_base::FallbackIconStyle& style = parsed.style();
232 EXPECT_EQ(SkColorSetRGB(0x00, 0x00, 0x00), style.background_color);
233 EXPECT_EQ(SkColorSetRGB(0xFF, 0xFF, 0xFF), style.text_color);
234 EXPECT_EQ(0.75, style.font_size_ratio);
235 EXPECT_EQ(0.25, style.roundness);
236 }
237
238 // Size and style are default.
239 {
240 chrome::ParsedFallbackIconPath parsed;
241 EXPECT_TRUE(parsed.Parse(std::string(",,,,/") + kTestUrlStr));
242 EXPECT_EQ(GURL(kTestUrlStr), parsed.url());
243 EXPECT_EQ(gfx::kFaviconSize, parsed.size_in_pixels());
244 const favicon_base::FallbackIconStyle& style = parsed.style();
245 EXPECT_EQ(kDefaultBackgroundColor, style.background_color);
246 EXPECT_EQ(kDefaultTextColorLight, style.text_color);
247 EXPECT_EQ(kDefaultFontSizeRatio, style.font_size_ratio);
248 EXPECT_EQ(kDefaultRoundness, style.roundness);
249 }
250 }
251
252 TEST_F(FallbackIconUrlParserTest, ParseFallbackIconPathFailure) {
253 const char* test_cases[] = {
254 // Bad size.
255 "-1,#000,#fff,0.75,0.25/http://www.google.com/",
256 // Bad specs.
257 "32,#junk,#fff,0.75,0.25/http://www.google.com/",
258 // Bad URL.
259 "32,#000,#fff,0.75,0.25/NOT A VALID URL",
260 };
261 for (size_t i = 0; i < arraysize(test_cases); ++i) {
262 chrome::ParsedFallbackIconPath parsed;
263 EXPECT_FALSE(parsed.Parse(test_cases[i])) << "test_cases[" << i << "]";
264 }
265 }
266
267 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/common/favicon/fallback_icon_url_parser.cc ('k') | skia/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698