Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 924043002: Revert of Update geolocation permission tests for the permission bubble (Closed)

Created:
5 years, 10 months ago by felt
Modified:
5 years, 10 months ago
CC:
chromium-reviews, markusheintz_, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update geolocation permission tests for the permission bubble (patchset #20 id:380001 of https://codereview.chromium.org/787033004/) Reason for revert: Still flaky. See https://code.google.com/p/chromium/issues/detail?id=458563 Original issue's description: > Update geolocation permission tests for the permission bubble > > This makes the geolocation permission tests run for both infobars and > permission bubbles. The tests now run as parameterized tests. > > Supercedes parts of: > https://codereview.chromium.org/411503005/ > https://codereview.chromium.org/341833004/ > > BUG=438758 > > Committed: https://crrev.com/f57c61952870c6027dbf220eff8b2d703bfed3c8 > Cr-Commit-Position: refs/heads/master@{#314541} > > Committed: https://crrev.com/d9f24fc092eba7accd05df923b1a1aa911a8ca38 > Cr-Commit-Position: refs/heads/master@{#315883} TBR=mvanouwerkerk@chromium.org,timvolodine@google.com,markusheintz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=438758 Committed: https://crrev.com/850ae65e83e37adea6b5a81c4fd9a0d6d9306a27 Cr-Commit-Position: refs/heads/master@{#316229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -828 lines) Patch
M chrome/browser/geolocation/geolocation_browsertest.cc View 32 chunks +134 lines, -221 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 19 chunks +298 lines, -488 lines 0 comments Download
D chrome/browser/ui/website_settings/mock_permission_bubble_view.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/website_settings/mock_permission_bubble_view.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
felt
Created Revert of Update geolocation permission tests for the permission bubble
5 years, 10 months ago (2015-02-13 17:01:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924043002/1
5 years, 10 months ago (2015-02-13 17:01:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 17:02:00 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 17:02:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/850ae65e83e37adea6b5a81c4fd9a0d6d9306a27
Cr-Commit-Position: refs/heads/master@{#316229}

Powered by Google App Engine
This is Rietveld 408576698