Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 924033003: IndexedDB: Ensure that blobs in unused prefetches are acked (Closed)

Created:
5 years, 10 months ago by jsbell
Modified:
5 years, 10 months ago
Reviewers:
cmumford
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Ensure that blobs in unused prefetches are acked When the browser sends a blob reference to the renderer it holds an extra reference until the renderer "acks" receipt, to keep the blob alive. Normally this is done when a "result" containing blobs is handed off to a blink::IDBRequest. When we "prefetch" for a cursor, multiple results are sent from the browser to the renderer at once, but only seen by blink::IDBRequest when script actually requests them. If script never does (e.g. it abandons a cursor midway through iteration) then the blobs would never be acked. Add blob acking to the cleanup step when prefetch entries are dropped. BUG=457498 R=cmumford@chromium.org Committed: https://crrev.com/0dd33709e0a2cbf5c30d76d1dd3367fce9afa6ed Cr-Commit-Position: refs/heads/master@{#316688}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak store name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl.cc View 2 chunks +13 lines, -0 lines 0 comments Download
A content/test/data/indexeddb/blob_did_ack_prefetch.html View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
jsbell
cmumford@ - please take a look?
5 years, 10 months ago (2015-02-17 17:54:53 UTC) #1
cmumford
https://codereview.chromium.org/924033003/diff/1/content/test/data/indexeddb/blob_did_ack_prefetch.html File content/test/data/indexeddb/blob_did_ack_prefetch.html (right): https://codereview.chromium.org/924033003/diff/1/content/test/data/indexeddb/blob_did_ack_prefetch.html#newcode14 content/test/data/indexeddb/blob_did_ack_prefetch.html:14: var store_name = 'blobs_ack'; Are we guaranteed this name ...
5 years, 10 months ago (2015-02-17 18:13:49 UTC) #2
jsbell
https://codereview.chromium.org/924033003/diff/1/content/test/data/indexeddb/blob_did_ack_prefetch.html File content/test/data/indexeddb/blob_did_ack_prefetch.html (right): https://codereview.chromium.org/924033003/diff/1/content/test/data/indexeddb/blob_did_ack_prefetch.html#newcode14 content/test/data/indexeddb/blob_did_ack_prefetch.html:14: var store_name = 'blobs_ack'; On 2015/02/17 18:13:49, cmumford wrote: ...
5 years, 10 months ago (2015-02-17 18:15:11 UTC) #3
jsbell
> We should not be preserving state across tests, but I'll change it anyway. Also, ...
5 years, 10 months ago (2015-02-17 18:23:38 UTC) #4
cmumford
lgtm
5 years, 10 months ago (2015-02-17 18:24:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924033003/20001
5 years, 10 months ago (2015-02-17 18:25:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/2440)
5 years, 10 months ago (2015-02-17 20:35:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924033003/20001
5 years, 10 months ago (2015-02-17 21:02:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 22:56:08 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:56:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dd33709e0a2cbf5c30d76d1dd3367fce9afa6ed
Cr-Commit-Position: refs/heads/master@{#316688}

Powered by Google App Engine
This is Rietveld 408576698