Supervised Users: Replace kForceSafeSearch pref with kForceGoogleSearch and kForceYouTubeSafetyMode.

Supervised Users: Replace kForceSafeSearch pref with kForceGoogleSearch and kForceYouTubeSafetyMode.

BUG=458546
Committed: https://crrev.com/831f88e820fc75933d70b27035e5106c06cb07ab
Cr-Commit-Position: refs/heads/master@{#317564}

[Bernhard Bauer, 2015-02-20 11:15:06]

bauerb@chromium.org changed reviewers:
+ pam@chromium.org

[Bernhard Bauer, 2015-02-20 11:15:07]

Please review.

[Marc Treib, 2015-02-23 09:08:38]

treib@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2015-02-23 09:08:39]

Drive-by lgtm (with nits) :)

https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc
(right):

https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc:119:
EXPECT_TRUE(force_safesearch);
Also add a check for kForceYouTubeSafetyMode?

https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc:147:
EXPECT_FALSE(force_safesearch);
Here too.

https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_service_browsertest.cc
(right):

https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_service_browsertest.cc:85:
EXPECT_TRUE(prefs->IsUserModifiablePreference(prefs::kForceGoogleSafeSearch));
And if you feel like it, here (and below) also.

[Bernhard Bauer, 2015-02-23 09:20:27]

New patchsets have been uploaded after l-g-t-m from treib@chromium.org

[Bernhard Bauer, 2015-02-23 09:24:19]

On 2015/02/23 09:08:39, Marc Treib - OOO until Feb 23 wrote:
> Drive-by lgtm (with nits) :)
> 
>
https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
> File chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
> chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc:119:
> EXPECT_TRUE(force_safesearch);
> Also add a check for kForceYouTubeSafetyMode?
> 
>
https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
> chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc:147:
> EXPECT_FALSE(force_safesearch);
> Here too.
> 
>
https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
> File chrome/browser/supervised_user/supervised_user_service_browsertest.cc
> (right):
> 
>
https://codereview.chromium.org/924033002/diff/20001/chrome/browser/supervise...
> chrome/browser/supervised_user/supervised_user_service_browsertest.cc:85:
> EXPECT_TRUE(prefs->IsUserModifiablePreference(prefs::kForceGoogleSafeSearch));
> And if you feel like it, here (and below) also.

Done.

(In general though, I don't expect these tests to cover the full set of prefs
that are set by default and that can be configured, just a subset to see whether
the general mechanism works. Otherwise this would quickly devolve to just making
each change twice: once in the code, once in the test).

[Bernhard Bauer, 2015-02-23 09:24:23]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2015-02-23 09:24:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/924033002/40001

[commit-bot: I haz the power, 2015-02-23 09:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 09:27:34]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Pam (message me for reviews), 2015-02-23 10:21:47]

LGTM too

[Bernhard Bauer, 2015-02-23 10:23:27]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2015-02-23 10:24:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/924033002/40001

[commit-bot: I haz the power, 2015-02-23 11:00:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-23 11:01:26]

Patchset 3 (id:??) landed as
https://crrev.com/831f88e820fc75933d70b27035e5106c06cb07ab
Cr-Commit-Position: refs/heads/master@{#317564}