Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 924023003: gpu: Initialize GLFakeQueries data members. (Closed)

Created:
5 years, 10 months ago by Daniele Castagna
Modified:
5 years, 10 months ago
Reviewers:
Nico, David Yen, vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Initialize GLFakeQueries data members. DrMemory reported uninitialized read for GPUTiming::CheckAndResetTimerErrors. This was probably caused by GLFakeQueries::disjointed_ not being properly initialized and being read in GPUTiming::GetIntegerv. BUG=458607 Committed: https://crrev.com/5d29007ab52dab6dad7c58a29aa39031a1781af0 Cr-Commit-Position: refs/heads/master@{#316279}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove default constructor calls for class memeber variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gpu/command_buffer/service/gpu_tracer_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Daniele Castagna
5 years, 10 months ago (2015-02-13 19:41:33 UTC) #2
Nico
https://codereview.chromium.org/924023003/diff/1/gpu/command_buffer/service/gpu_tracer_unittest.cc File gpu/command_buffer/service/gpu_tracer_unittest.cc (right): https://codereview.chromium.org/924023003/diff/1/gpu/command_buffer/service/gpu_tracer_unittest.cc#newcode52 gpu/command_buffer/service/gpu_tracer_unittest.cc:52: GlFakeQueries() : alloced_queries_(), query_timestamp_() {} You don't need this. ...
5 years, 10 months ago (2015-02-13 19:42:51 UTC) #3
Daniele Castagna
https://codereview.chromium.org/924023003/diff/1/gpu/command_buffer/service/gpu_tracer_unittest.cc File gpu/command_buffer/service/gpu_tracer_unittest.cc (right): https://codereview.chromium.org/924023003/diff/1/gpu/command_buffer/service/gpu_tracer_unittest.cc#newcode52 gpu/command_buffer/service/gpu_tracer_unittest.cc:52: GlFakeQueries() : alloced_queries_(), query_timestamp_() {} On 2015/02/13 at 19:42:51, ...
5 years, 10 months ago (2015-02-13 19:46:44 UTC) #4
Nico
lgtm, thanks!
5 years, 10 months ago (2015-02-13 19:50:42 UTC) #5
vmiura
lgtm
5 years, 10 months ago (2015-02-13 20:12:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/924023003/20001
5 years, 10 months ago (2015-02-13 20:21:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 20:34:57 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:35:50 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5d29007ab52dab6dad7c58a29aa39031a1781af0
Cr-Commit-Position: refs/heads/master@{#316279}

Powered by Google App Engine
This is Rietveld 408576698