Issue 924023002: Subzero: Make threads=2 and filetype=obj the testing defaults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 924023002: Subzero: Make threads=2 and filetype=obj the testing defaults. (Closed)

Created:
5 years, 10 months ago by Jim Stichnoth

Modified:
5 years, 10 months ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Subzero: Make threads=2 and filetype=obj the testing defaults. Change crosstest.py's -elf argument to the now-standard -filetype and just pass it through to llvm2ice. This also fixes a leftover -elf-writer argument that should have been changed to -filetype=obj. It would be nice to change all the explicit -threads=0 to -threads=1 in the lit tests, but that uncovers too many assumptions about dump/emit output order, or ordering between function and global data emission. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9f76aec798faf3adfabd7d136ac048a834f5a6b5

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -9 lines)			Patch
M	pydir/crosstest.py	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/llvm2ice.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests_lit/llvm2ice_tests/globalrelocs.ll	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

5 years, 10 months ago (2015-02-13 18:00:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9f76aec798faf3adfabd7d136ac048a834f5a6b5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages