Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2710)

Unified Diff: build/android/pylib/device/device_utils_test.py

Issue 924003003: [Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/device/device_utils_test.py
diff --git a/build/android/pylib/device/device_utils_test.py b/build/android/pylib/device/device_utils_test.py
index 6071fd57a069ebc625ca304c62ca0becf37a4e37..9dc765431edcd7206304822adf21321daea2749b 100755
--- a/build/android/pylib/device/device_utils_test.py
+++ b/build/android/pylib/device/device_utils_test.py
@@ -1399,22 +1399,18 @@ class DeviceUtilsGetIOStatsTest(DeviceUtilsOldImplTest):
self.device.GetIOStats())
-class DeviceUtilsGetMemoryUsageForPidTest(DeviceUtilsOldImplTest):
+class DeviceUtilsGetMemoryUsageForPidTest(DeviceUtilsNewImplTest):
def setUp(self):
super(DeviceUtilsGetMemoryUsageForPidTest, self).setUp()
- self.device.old_interface._privileged_command_runner = (
- self.device.old_interface.RunShellCommand)
- self.device.old_interface._protected_file_access_method_initialized = True
def testGetMemoryUsageForPid_validPid(self):
- with self.assertCallsSequence([
- ("adb -s 0123456789abcdef shell 'showmap 1234'",
- '100 101 102 103 104 105 106 107 TOTAL\r\n'),
- ("adb -s 0123456789abcdef shell "
- "'cat \"/proc/1234/status\" 2> /dev/null'",
- 'VmHWM: 1024 kB')
- ]):
+ with self.assertCalls(
+ (self.call.device.RunShellCommand(
+ ['showmap', '1234'], as_root=True, check_return=True),
+ ['100 101 102 103 104 105 106 107 TOTAL']),
+ (self.call.device.ReadFile('/proc/1234/status', as_root=True),
+ 'VmHWM: 1024 kB\n')):
self.assertEqual(
{
'Size': 100,
@@ -1428,11 +1424,33 @@ class DeviceUtilsGetMemoryUsageForPidTest(DeviceUtilsOldImplTest):
},
self.device.GetMemoryUsageForPid(1234))
- def testGetMemoryUsageForPid_invalidPid(self):
+ def testGetMemoryUsageForPid_noSmaps(self):
+ with self.assertCalls(
+ (self.call.device.RunShellCommand(
+ ['showmap', '4321'], as_root=True, check_return=True),
+ ['cannot open /proc/4321/smaps: No such file or directory']),
+ (self.call.device.ReadFile('/proc/4321/status', as_root=True),
+ 'VmHWM: 1024 kb\n')):
+ self.assertEquals({'VmHWM': 1024}, self.device.GetMemoryUsageForPid(4321))
+
+ def testGetMemoryUsageForPid_noStatus(self):
with self.assertCalls(
- "adb -s 0123456789abcdef shell 'showmap 4321'",
- 'cannot open /proc/4321/smaps: No such file or directory\r\n'):
- self.assertEqual({}, self.device.GetMemoryUsageForPid(4321))
+ (self.call.device.RunShellCommand(
+ ['showmap', '4321'], as_root=True, check_return=True),
+ ['100 101 102 103 104 105 106 107 TOTAL']),
+ (self.call.device.ReadFile('/proc/4321/status', as_root=True),
+ self.CommandError())):
+ self.assertEquals(
+ {
+ 'Size': 100,
+ 'Rss': 101,
+ 'Pss': 102,
+ 'Shared_Clean': 103,
+ 'Shared_Dirty': 104,
+ 'Private_Clean': 105,
+ 'Private_Dirty': 106,
+ },
+ self.device.GetMemoryUsageForPid(4321))
class DeviceUtilsStrTest(DeviceUtilsNewImplTest):
« build/android/pylib/device/device_utils.py ('K') | « build/android/pylib/device/device_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698