[Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper.

[Android] Migrate DeviceUtils.GetMemoryUsageForPid to adb_wrapper.

BUG=267773
Committed: https://crrev.com/bcec82d59869b43f0507d244e84798c6ce1cfcf9
Cr-Commit-Position: refs/heads/master@{#316624}

[jbudorick, 2015-02-13 20:43:24]

jbudorick@chromium.org changed reviewers:
+ perezju@chromium.org

[jbudorick, 2015-02-13 20:43:25]

I wavered on whether to raise an exception if anything goes wrong vs just not
populating the dict if something goes wrong. I opted to stick with the existing
behavior because that's what the current client (telemetry's
android_platform_backend.py) expects. I'm open to switching, though.

[perezju, 2015-02-16 11:17:58]

On 2015/02/13 20:43:25, jbudorick wrote:
> I wavered on whether to raise an exception if anything goes wrong vs just not
> populating the dict if something goes wrong. I opted to stick with the
existing
> behavior because that's what the current client (telemetry's
> android_platform_backend.py) expects. I'm open to switching, though.

Yeah, I'm not too happy with the interface either. Also the fact that it returns
a defaultdict, since this hides missing values as 0's (as opposed to None or
just not being there). Anyway, I also agree that it's perhaps best to keep the
same interface which telemetry expects for now. Hopefully the memory efforts
(which include some improvements in telemetry) will eventually make things
better.

Otherwise lgtm, with a small nit.

https://codereview.chromium.org/924003003/diff/20001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/924003003/diff/20001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:1368: (int(split_totals[i]) for i in
xrange(0, len(SMAPS_COLUMNS)))))
I would just write:

   (int(num) for num in split_totals)

izip will already discard the non-matching extra columns.

[jbudorick, 2015-02-17 16:44:09]

New patchsets have been uploaded after l-g-t-m from perezju@chromium.org

[jbudorick, 2015-02-17 16:59:15]

https://codereview.chromium.org/924003003/diff/20001/build/android/pylib/devi...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/924003003/diff/20001/build/android/pylib/devi...
build/android/pylib/device/device_utils.py:1368: (int(split_totals[i]) for i in
xrange(0, len(SMAPS_COLUMNS)))))
On 2015/02/16 11:17:57, perezju wrote:
> I would just write:
> 
>    (int(num) for num in split_totals)
> 
> izip will already discard the non-matching extra columns.

Done.

https://codereview.chromium.org/924003003/diff/80001/build/android/pylib/devi...
File build/android/pylib/device/device_utils_test.py (left):

https://codereview.chromium.org/924003003/diff/80001/build/android/pylib/devi...
build/android/pylib/device/device_utils_test.py:124: class
DeviceUtilsOldImplTest(unittest.TestCase):
After rebasing, this had no more clients, so I removed it and renamed
DeviceUtilsNewImplTest to DeviceUtilsTest.

[jbudorick, 2015-02-17 16:59:20]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-02-17 17:00:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/924003003/80001

[commit-bot: I haz the power, 2015-02-17 19:33:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-17 19:34:38]

Patchset 5 (id:??) landed as
https://crrev.com/bcec82d59869b43f0507d244e84798c6ce1cfcf9
Cr-Commit-Position: refs/heads/master@{#316624}

[jam, 2015-02-17 21:11:03]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/934893002/ by jam@chromium.org.

The reason for reverting is: Collision with
https://codereview.chromium.org/929603002, see failurs on trybots like
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes....