Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 923963003: Fixes RTL assets popping up in LTR text in JB MR0 (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes RTL assets popping up in LTR text in JB MR0 RTL language support existed in JB MR0 but RTL layout support didn't show up until the next release. Moves all of the v16 folders to v17 BUG=426820 Committed: https://crrev.com/457a3a637ef45e5606e74a43fb69d6fa2075cda6 Cr-Commit-Position: refs/heads/master@{#316268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -14 lines) Patch
A + chrome/android/java/res/drawable-ldrtl-hdpi-v17/btn_toolbar_reload.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-hdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-hdpi/btn_toolbar_reload.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-hdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-mdpi-v17/btn_toolbar_reload.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-mdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-mdpi/btn_toolbar_reload.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-mdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-sw600dp-hdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-sw600dp-hdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-sw600dp-mdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-sw600dp-mdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-sw600dp-xhdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-sw600dp-xhdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-sw600dp-xxhdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-sw600dp-xxhdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-sw600dp-xxxhdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-sw600dp-xxxhdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-v17/btn_back.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-v17/btn_forward.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-xhdpi-v17/btn_toolbar_reload.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-xhdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xhdpi/btn_toolbar_reload.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xhdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/btn_toolbar_reload.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-xxhdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xxhdpi/btn_toolbar_reload.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xxhdpi/edge_menu_bg.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/btn_toolbar_reload.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-ldrtl-xxxhdpi-v17/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xxxhdpi/btn_toolbar_reload.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xxxhdpi/edge_menu_bg.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl/btn_back.xml View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/android/java/res/drawable-ldrtl/btn_forward.xml View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 10 months ago (2015-02-13 19:43:14 UTC) #2
Ted C
rs lgtm
5 years, 10 months ago (2015-02-13 19:45:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923963003/1
5 years, 10 months ago (2015-02-13 19:50:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 20:10:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:10:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/457a3a637ef45e5606e74a43fb69d6fa2075cda6
Cr-Commit-Position: refs/heads/master@{#316268}

Powered by Google App Engine
This is Rietveld 408576698