Migrate cast to use JNIOnLoadDelegate

Migrate cast to use JNIOnLoadDelegate

BUG=447393
Committed: https://crrev.com/5d4a4c5f9e60cdf954f23fa9de5a669adda475ed
Cr-Commit-Position: refs/heads/master@{#316351}

[michaelbai, 2015-02-13 22:00:40]

michaelbai@chromium.org changed reviewers:
+ gunsch@chromium.org

[michaelbai, 2015-02-13 22:08:10]

PTAL

[gunsch, 2015-02-13 22:22:38]

On 2015/02/13 22:08:10, michaelbai wrote:
> PTAL

Can you "git cl try -m tryserver.chromium.linux -b cast_shell_apk" ?

[gunsch, 2015-02-13 23:31:29]

On 2015/02/13 22:22:38, gunsch wrote:
> On 2015/02/13 22:08:10, michaelbai wrote:
> > PTAL
> 
> Can you "git cl try -m tryserver.chromium.linux -b cast_shell_apk" ?

Blah. Looks like our build is broken. Guess this is why we're working on getting
a trybot up :)

Lgtm in the meantime, the code looks fine to me.

[gunsch, 2015-02-13 23:45:06]

On 2015/02/13 23:31:29, gunsch wrote:
> On 2015/02/13 22:22:38, gunsch wrote:
> > On 2015/02/13 22:08:10, michaelbai wrote:
> > > PTAL
> > 
> > Can you "git cl try -m tryserver.chromium.linux -b cast_shell_apk" ?
> 
> Blah. Looks like our build is broken. Guess this is why we're working on
getting
> a trybot up :)
> 
> Lgtm in the meantime, the code looks fine to me.

Actually, looks like it was your CL that broke it...

https://codereview.chromium.org/897683003

browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java:65:
error: non-static method ensureInitialized() cannot be referenced from a static
context
            LibraryLoader.ensureInitialized();
                         ^
browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java:68:
error: method get in class BrowserStartupController cannot be applied to given
types;
           
BrowserStartupController.get(context).startBrowserProcessesSync(false);
                                    ^
do you have bandwidth to fix that as well, maybe even in this CL?

[michaelbai, 2015-02-13 23:52:54]

New patchsets have been uploaded after l-g-t-m from gunsch@chromium.org

[gunsch, 2015-02-14 00:58:30]

On 2015/02/13 23:45:06, gunsch wrote:
> On 2015/02/13 23:31:29, gunsch wrote:
> > On 2015/02/13 22:22:38, gunsch wrote:
> > > On 2015/02/13 22:08:10, michaelbai wrote:
> > > > PTAL
> > > 
> > > Can you "git cl try -m tryserver.chromium.linux -b cast_shell_apk" ?
> > 
> > Blah. Looks like our build is broken. Guess this is why we're working on
> getting
> > a trybot up :)
> > 
> > Lgtm in the meantime, the code looks fine to me.
> 
> Actually, looks like it was your CL that broke it...
> 
> https://codereview.chromium.org/897683003
> 
>
browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java:65:
> error: non-static method ensureInitialized() cannot be referenced from a
static
> context
>             LibraryLoader.ensureInitialized();
>                          ^
>
browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java:68:
> error: method get in class BrowserStartupController cannot be applied to given
> types;
>            
> BrowserStartupController.get(context).startBrowserProcessesSync(false);
>                                     ^
> do you have bandwidth to fix that as well, maybe even in this CL?

Lgtm based on second PatchSet trybot run. FYI the compile tests step will fail
and is a known issue, but looks like compile cast_shell step succeeded. Thanks!

[michaelbai, 2015-02-14 01:04:43]

On 2015/02/14 00:58:30, gunsch wrote:
> On 2015/02/13 23:45:06, gunsch wrote:
> > On 2015/02/13 23:31:29, gunsch wrote:
> > > On 2015/02/13 22:22:38, gunsch wrote:
> > > > On 2015/02/13 22:08:10, michaelbai wrote:
> > > > > PTAL
> > > > 
> > > > Can you "git cl try -m tryserver.chromium.linux -b cast_shell_apk" ?
> > > 
> > > Blah. Looks like our build is broken. Guess this is why we're working on
> > getting
> > > a trybot up :)
> > > 
> > > Lgtm in the meantime, the code looks fine to me.
> > 
> > Actually, looks like it was your CL that broke it...
> > 
> > https://codereview.chromium.org/897683003
> > 
> >
>
browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java:65:
> > error: non-static method ensureInitialized() cannot be referenced from a
> static
> > context
> >             LibraryLoader.ensureInitialized();
> >                          ^
> >
>
browser/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java:68:
> > error: method get in class BrowserStartupController cannot be applied to
given
> > types;
> >            
> > BrowserStartupController.get(context).startBrowserProcessesSync(false);
> >                                     ^
> > do you have bandwidth to fix that as well, maybe even in this CL?
> 
> Lgtm based on second PatchSet trybot run. FYI the compile tests step will fail
> and is a known issue, but looks like compile cast_shell step succeeded.
Thanks!

Thanks, I will go ahead to land it, hope your bot be cq bot soon, it is pretty
slow now.

[michaelbai, 2015-02-14 01:04:49]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2015-02-14 01:05:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/923953005/20001

[commit-bot: I haz the power, 2015-02-14 01:24:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-14 01:25:23]

Patchset 2 (id:??) landed as
https://crrev.com/5d4a4c5f9e60cdf954f23fa9de5a669adda475ed
Cr-Commit-Position: refs/heads/master@{#316351}