Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 923933002: Files.app: Replace volume icons with final version of them. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Replace volume icons with final version of them. BUG=402344 Committed: https://crrev.com/021b2e00ecddb27569ce525e4b7f0173b3e09615 Cr-Commit-Position: refs/heads/master@{#316205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -32 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_types.css View 1 chunk +100 lines, -32 lines 0 comments Download
M ui/file_manager/file_manager/foreground/images/volumes/2x/archive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/archive_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_archive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_downloads.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_drive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_hdd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_offline.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_optical.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_phone.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_recent.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_sd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_shared.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_trash.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/black_usb.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/cd.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/cd_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/device_hd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/device_optical.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/device_sd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/device_sd_large.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/device_usb.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/device_usb_large.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/images/volumes/2x/downloads.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/downloads_active.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/images/volumes/2x/drive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/drive_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/drive_offline.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/drive_recent.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/drive_shared.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/folder.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/hard_drive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/hard_drive_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/offline.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/offline_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/phone.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/phone_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/recent.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/recent_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/sd.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/sd_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/service_drive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/service_drive_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/shared.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/shared_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/usb.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/usb_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/white_trash.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/archive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/archive_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_archive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_downloads.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_drive.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_folder.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_hdd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_offline.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_optical.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_phone.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_recent.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_sd.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_shared.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_trash.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/black_usb.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/cd.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/cd_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/device_sd_large.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/device_usb_large.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/downloads.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/downloads_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/drive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/drive_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/hard_drive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/hard_drive_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/offline.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/offline_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/phone.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/phone_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/recent.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/recent_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/sd.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/sd_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/service_drive.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/service_drive_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/shared.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/shared_active.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/usb.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/usb_active.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_folder.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/white_trash.png View Binary file 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
Could you take a look? Thanks!
5 years, 10 months ago (2015-02-13 10:38:58 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-13 11:19:48 UTC) #3
fukino
On 2015/02/13 11:19:48, yawano wrote: > lgtm. Thank you! Thank you!
5 years, 10 months ago (2015-02-13 11:25:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923933002/1
5 years, 10 months ago (2015-02-13 11:28:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 12:24:06 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 12:24:58 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/021b2e00ecddb27569ce525e4b7f0173b3e09615
Cr-Commit-Position: refs/heads/master@{#316205}

Powered by Google App Engine
This is Rietveld 408576698