Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 923913004: Use an empty origin as source origin when posting messages from android_webview (Closed)

Created:
5 years, 10 months ago by sgurun-gerrit only
Modified:
5 years, 10 months ago
Reviewers:
hush (inactive), mnaganov
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

There is no point of keeping source_origin as a parameter in postMessageTo* methods. It is not a parameter to expose to the source app in a webview API, and it is not a value that will change from one request to another, so for the simplicity's sake, remove it from java side completely. At the moment, I am not fully sure what a good value is so leaving it as a empty domain for now. BUG=393291 Committed: https://crrev.com/274fd4ebccc314bd99dbf328d614d4e615f69ce3 Cr-Commit-Position: refs/heads/master@{#316295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -65 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +8 lines, -11 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/MessagePort.java View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/PostMessageSender.java View 5 chunks +13 lines, -16 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java View 10 chunks +26 lines, -29 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/native/aw_contents.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sgurun-gerrit only
ptal, thanks.
5 years, 10 months ago (2015-02-13 20:18:10 UTC) #2
hush (inactive)
lgtm
5 years, 10 months ago (2015-02-13 21:14:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923913004/1
5 years, 10 months ago (2015-02-13 21:14:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 21:36:35 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 21:37:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/274fd4ebccc314bd99dbf328d614d4e615f69ce3
Cr-Commit-Position: refs/heads/master@{#316295}

Powered by Google App Engine
This is Rietveld 408576698