Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 923863002: Sort GN files under chrome (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort GN files under chrome For tools/sort_sources.py to be useful, existing GYP files should be sorted. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/b7a72eaaa731a39ef36b6aa79ee808222f2aac96 Cr-Commit-Position: refs/heads/master@{#316184}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_watcher/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/perf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/profile_reset/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
satorux1
https://codereview.chromium.org/923863002/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/923863002/diff/1/chrome/test/BUILD.gn#newcode1450 chrome/test/BUILD.gn:1450: # Android doesn't support download feedbacks. this was manually ...
5 years, 10 months ago (2015-02-13 06:59:51 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-13 07:15:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923863002/20001
5 years, 10 months ago (2015-02-13 07:17:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-13 07:20:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 07:20:53 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b7a72eaaa731a39ef36b6aa79ee808222f2aac96
Cr-Commit-Position: refs/heads/master@{#316184}

Powered by Google App Engine
This is Rietveld 408576698