Issue 923853002: Sort GN files under base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 923853002: Sort GN files under base (Closed)

Created:
5 years, 10 months ago by satorux1

Modified:
5 years, 10 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, wfh+watch_chromium.org, erikwright+watch_chromium.org, Dai Mikurube (NOT FULLTIME)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Sort GN files under base For tools/sort_sources.py to be useful, existing GYP files should be sorted. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/b7ce34930ca44306117eef8a14191cf39bcd0083 Cr-Commit-Position: refs/heads/master@{#316183}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -48 lines)			Patch
M	base/BUILD.gn	View	24 chunks	+45 lines, -45 lines	0 comments	Download
M	base/allocator/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/third_party/dynamic_annotations/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923853002/1

5 years, 10 months ago (2015-02-13 07:07:28 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-13 07:14:01 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b7ce34930ca44306117eef8a14191cf39bcd0083
Cr-Commit-Position: refs/heads/master@{#316183}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages