Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 923803003: Fix up a few more lint warnings in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo changes in autofill_profile_editor Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/autofill_card_unmask_prompt.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 23 matching lines...) Expand all
34 <issue id="DrawAllocation"> 34 <issue id="DrawAllocation">
35 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewRenderView.java"/> 35 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewRenderView.java"/>
36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/> 36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/>
37 </issue> 37 </issue>
38 <issue id="ExportedContentProvider"> 38 <issue id="ExportedContentProvider">
39 <ignore path="AndroidManifest.xml"/> 39 <ignore path="AndroidManifest.xml"/>
40 </issue> 40 </issue>
41 <issue id="HandlerLeak"> 41 <issue id="HandlerLeak">
42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> 42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/>
43 </issue> 43 </issue>
44 <issue id="IconDensities">
45 <!-- crbug.com/457918 is tracking missing assets -->
46 <ignore path="content/public/android/java/res/drawable-xxhdpi"/>
47 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>
48 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
49 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
50 <ignore path="ui/android/java/res/drawable-xxhdpi"/>
51 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
52 </issue>
53 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. -->
54 <issue id="IconLocation">
55 <ignore path="content/shell/android/java/res/"/>
56 <ignore path="chrome/android/shell/res/"/>
57 </issue>
44 <issue id="MissingApplicationIcon" severity="ignore"/> 58 <issue id="MissingApplicationIcon" severity="ignore"/>
45 <issue id="MissingRegistered" severity="ignore"/> 59 <issue id="MissingRegistered" severity="ignore"/>
46 <issue id="MissingVersion"> 60 <issue id="MissingVersion">
47 <ignore path="AndroidManifest.xml"/> 61 <ignore path="AndroidManifest.xml"/>
48 </issue> 62 </issue>
49 <!-- Disabling is InlinedApi and NewApi is bad but we have too many of these e rrors and nobody is fixing it. crbug.com/411461 --> 63 <!-- Disabling is InlinedApi and NewApi is bad but we have too many of these e rrors and nobody is fixing it. crbug.com/411461 -->
50 <issue id="InlinedApi" severity="ignore"/> 64 <issue id="InlinedApi" severity="ignore"/>
51 <issue id="NewApi" severity="ignore"/> 65 <issue id="NewApi" severity="ignore"/>
52 <issue id="OldTargetApi"> 66 <issue id="OldTargetApi">
53 <ignore path="AndroidManifest.xml"/> 67 <ignore path="AndroidManifest.xml"/>
54 </issue> 68 </issue>
69 <issue id="Overdraw" severity="ignore"/>
55 <issue id="Recycle" severity="ignore"/> 70 <issue id="Recycle" severity="ignore"/>
56 <issue id="Registered" severity="ignore"/> 71 <issue id="Registered" severity="ignore"/>
72 <issue id="RtlEnabled" severity="ignore"/>
57 <issue id="SdCardPath"> 73 <issue id="SdCardPath">
58 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> 74 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/>
59 </issue> 75 </issue>
60 <issue id="SetJavaScriptEnabled" severity="ignore"/> 76 <issue id="SetJavaScriptEnabled" severity="ignore"/>
77 <issue id="UnusedResources">
78 <!-- TODO(aurimas): remove suppression once crbug.com/458328 is fixed. -->
79 <ignore path="content/public/android/java/res/layout/validation_message_bubb le.xml" />
80
81 <!-- These files are used by chrome_shell_apk and chrome_apk targets. -->
82 <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" />
83 <ignore path="chrome/android/java/res/drawable/btn_back.xml" />
84 <ignore path="chrome/android/java/res/drawable/btn_forward.xml" />
85 </issue>
61 <issue id="ViewConstructor" severity="ignore"/> 86 <issue id="ViewConstructor" severity="ignore"/>
62 <issue id="WrongCall" severity="ignore"/> 87 <issue id="WrongCall" severity="ignore"/>
63 </lint> 88 </lint>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/res/layout/autofill_card_unmask_prompt.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698