Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 923773003: Revert of Remove dependency on content from remoting_host. (Closed)

Created:
5 years, 10 months ago by Charlie Reis
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov, kelvinp
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, chromoting-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove dependency on content from remoting_host. (patchset #5 id:160001 of https://codereview.chromium.org/929493002/) Reason for revert: Compile failure on Linux ChromiumOS Ozone Builder: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/11867 Original issue's description: > Remove dependency on content from remoting_host. > > The host was depending on content just to access content::BrowserThread. > It's cleaner to just pass the references to the threads explicitly. > > BUG=458581 > > Committed: https://crrev.com/d5197934178ef0da1b630792cfbda8ddb6b34388 > Cr-Commit-Position: refs/heads/master@{#316648} TBR=kelvinp@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458581 Committed: https://crrev.com/34ca873ecd8905a90f9acfc6e840fb84671895af Cr-Commit-Position: refs/heads/master@{#316661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -87 lines) Patch
M chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc View 2 chunks +1 line, -8 lines 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/chromeos/clipboard_aura.h View 3 chunks +7 lines, -9 lines 0 comments Download
M remoting/host/chromeos/clipboard_aura.cc View 4 chunks +76 lines, -26 lines 0 comments Download
M remoting/host/chromeos/clipboard_aura_unittest.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M remoting/host/chromoting_host_context.h View 2 chunks +1 line, -8 lines 0 comments Download
M remoting/host/chromoting_host_context.cc View 2 chunks +37 lines, -26 lines 0 comments Download
M remoting/host/input_injector_chromeos.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/remoting_host.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Created Revert of Remove dependency on content from remoting_host.
5 years, 10 months ago (2015-02-17 21:43:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923773003/1
5 years, 10 months ago (2015-02-17 21:44:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 21:46:34 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 21:47:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34ca873ecd8905a90f9acfc6e840fb84671895af
Cr-Commit-Position: refs/heads/master@{#316661}

Powered by Google App Engine
This is Rietveld 408576698