Issue 923753002: Revert of Remove SkPictureFlat.h include from SkDrawCommands.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 923753002: Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (Closed)

Created:
5 years, 10 months ago by robertphillips

Modified:
5 years, 10 months ago

Reviewers:
fmalita_google_do_not_use, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Remove SkPictureFlat.h include from SkDrawCommands.h (patchset #3 id:40001 of https://codereview.chromium.org/912403004/) Reason for revert: Erm - Chrome. Original issue's description: > Remove SkPictureFlat.h include from SkDrawCommands.h > > This cannot land until https://codereview.chromium.org/909353004/ (Prepare SkiaBenchmarkingExtensionTest for upcoming Skia changes) lands in Chromium > > Committed: https://skia.googlesource.com/skia/+/5a4c233a3657d12d836de388b41e30405b4ab976 > > Committed: https://skia.googlesource.com/skia/+/fa3a83d0fe53907e618346d3f1c17a95da1a9d22 TBR=reed@google.com,fmalita@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/3a092042bce0a8b7c43bf621cacdb2c644febeb2

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+323 lines, -227 lines)			Patch
M	debugger/SkDebugger.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.h	View	2 chunks	+18 lines, -20 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.cpp	View	2 chunks	+14 lines, -7 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.h	View	7 chunks	+68 lines, -62 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.cpp	View	33 chunks	+137 lines, -91 lines	0 comments	Download
M	tools/filtermain.cpp	View	10 chunks	+82 lines, -43 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Remove SkPictureFlat.h include from SkDrawCommands.h

5 years, 10 months ago (2015-02-12 21:28:01 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923753002/1

5 years, 10 months ago (2015-02-12 21:29:07 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-12 21:29:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3a092042bce0a8b7c43bf621cacdb2c644febeb2