Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 923713005: Refresh Public Suffix List to the latest version (Closed)

Created:
5 years, 10 months ago by Ryan Sleevi
Modified:
5 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffix List to the latest version This updates to the following revision: bad2a08db205 (2015-02-17 17:53 +0000) It includes changes from revision 97c40a737bda (2014-11-21 04:28 +0100) to revision bad2a08db205 (2015-02-17 17:53 +0000), listed at http://hg.mozilla.org/mozilla-central/log/bad2a08db205/netwerk/dns/effective_tld_names.dat R=pkasting@chromium.org BUG=37436 Committed: https://crrev.com/68bec16a7f552323f4ba4c59bd61a96826f116bd Cr-Commit-Position: refs/heads/master@{#317094}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Handle Private+Wildcard rules #

Patch Set 3 : Remove *.platform.sh until crbug.com/459802 is resolved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -33 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 1 2 86 chunks +389 lines, -33 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 1 2 97 chunks +119 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Ryan Sleevi
Peter, easy review I hope.
5 years, 10 months ago (2015-02-18 21:40:58 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/923713005/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/923713005/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode9159 net/base/registry_controlled_domains/effective_tld_names.dat:9159: eu-central-1.compute.amazonaws.com Looks like this should be swapped with ...
5 years, 10 months ago (2015-02-18 21:46:08 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/923713005/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/923713005/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode9159 net/base/registry_controlled_domains/effective_tld_names.dat:9159: eu-central-1.compute.amazonaws.com On 2015/02/18 21:46:08, Peter Kasting wrote: > Looks ...
5 years, 10 months ago (2015-02-18 21:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923713005/1
5 years, 10 months ago (2015-02-18 21:56:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/43885)
5 years, 10 months ago (2015-02-18 22:06:49 UTC) #7
Ryan Sleevi
On 2015/02/18 22:06:49, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-19 00:15:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923713005/40001
5 years, 10 months ago (2015-02-19 00:17:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/27877)
5 years, 10 months ago (2015-02-19 04:05:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923713005/40001
5 years, 10 months ago (2015-02-19 18:14:00 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-19 19:19:06 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:20:04 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68bec16a7f552323f4ba4c59bd61a96826f116bd
Cr-Commit-Position: refs/heads/master@{#317094}

Powered by Google App Engine
This is Rietveld 408576698