Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 923683002: Fix lazy parsing for functions that use super. (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix lazy parsing for functions that use super. The preparser needs to log the usage of super properties and then update the scope when we create the function later. BUG=v8:3888 LOG=N R=dslomov@chromium.org, marja Committed: https://crrev.com/765e002a4fce831c91393db6c1d464ef3f1264f5 Cr-Commit-Position: refs/heads/master@{#26642}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Increment the PreparserData version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M src/parser.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/parser.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/preparse-data.h View 5 chunks +13 lines, -3 lines 0 comments Download
M src/preparse-data-format.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/scopes.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/js-perf-test/Classes/super.js View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/harmony/classes-lazy-parsing.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
arv (Not doing code reviews)
cleanup
5 years, 10 months ago (2015-02-12 20:03:15 UTC) #1
arv (Not doing code reviews)
PTAL Marja: Just to be sure, since this change does not change the headers of ...
5 years, 10 months ago (2015-02-12 20:07:28 UTC) #2
Dmitry Lomov (no reviews)
lgtm but no idea about versioning
5 years, 10 months ago (2015-02-12 20:11:33 UTC) #3
marja
On 2015/02/12 20:07:28, arv wrote: > PTAL > > Marja: Just to be sure, since ...
5 years, 10 months ago (2015-02-13 17:12:05 UTC) #4
marja
(otherwise lgtm)
5 years, 10 months ago (2015-02-13 17:12:19 UTC) #5
arv (Not doing code reviews)
On 2015/02/13 at 17:12:05, marja wrote: > On 2015/02/12 20:07:28, arv wrote: > > PTAL ...
5 years, 10 months ago (2015-02-13 17:46:33 UTC) #6
arv (Not doing code reviews)
Increment the PreparserData version
5 years, 10 months ago (2015-02-13 17:50:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923683002/40001
5 years, 10 months ago (2015-02-13 17:51:19 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-13 18:34:57 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 18:35:18 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/765e002a4fce831c91393db6c1d464ef3f1264f5
Cr-Commit-Position: refs/heads/master@{#26642}

Powered by Google App Engine
This is Rietveld 408576698