Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 923653002: Upstream Enhanced Bookmark Model (2nd Trial) (Closed)

Created:
5 years, 10 months ago by Ian Wen
Modified:
5 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream Enhanced Bookmark Model (2nd Land) This is the data layer of enhanced bookmark. There is no reason why this class should live in private repository. BUG=428832 Previously landed in: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261 Reverted in: https://crrev.com/f40cb64710a333da6d554e98dfcc432cd6cf8f1f Committed: https://crrev.com/ec62d8d37848b12309994f10bf8457ae4fcabb8e Cr-Commit-Position: refs/heads/master@{#316085}

Patch Set 1 #

Messages

Total messages: 13 (4 generated)
Ian Wen
5 years, 10 months ago (2015-02-12 19:19:59 UTC) #2
Kibeom Kim (inactive)
lgtm
5 years, 10 months ago (2015-02-12 19:20:49 UTC) #3
cjhopman
lgtm
5 years, 10 months ago (2015-02-12 19:28:39 UTC) #4
newt (away)
lgtm
5 years, 10 months ago (2015-02-12 19:30:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923653002/1
5 years, 10 months ago (2015-02-12 19:32:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/32000)
5 years, 10 months ago (2015-02-12 20:46:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923653002/1
5 years, 10 months ago (2015-02-12 23:35:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 23:36:35 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 23:37:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec62d8d37848b12309994f10bf8457ae4fcabb8e
Cr-Commit-Position: refs/heads/master@{#316085}

Powered by Google App Engine
This is Rietveld 408576698