Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 923573003: Revert of [Android] Migrate javascript settings to a content setting from a pref. (Closed)

Created:
5 years, 10 months ago by Ted C
Modified:
5 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Migrate javascript settings to a content setting from a pref. (patchset #3 id:40001 of https://codereview.chromium.org/920583002/) Reason for revert: This breaks the ContentSettings#getJavaScriptEnabled, so that dependency needs to be cleared up. Original issue's description: > [Android] Migrate javascript settings to a content setting from a pref. > > This also adds a preferences migration function and tracking system to > handle future changes. > > BUG=454063 > > Committed: https://crrev.com/c404e85f318501565ebd0c8b3541fbc2e260b158 > Cr-Commit-Position: refs/heads/master@{#316023} TBR=newt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454063 Committed: https://crrev.com/f38a80da741a08c5bf722226a06325b784a40909 Cr-Commit-Position: refs/heads/master@{#316045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -48 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java View 4 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 chunk +11 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ted C
Created Revert of [Android] Migrate javascript settings to a content setting from a pref.
5 years, 10 months ago (2015-02-12 20:52:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923573003/1
5 years, 10 months ago (2015-02-12 20:53:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 20:54:20 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 20:55:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f38a80da741a08c5bf722226a06325b784a40909
Cr-Commit-Position: refs/heads/master@{#316045}

Powered by Google App Engine
This is Rietveld 408576698