Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 923573002: Properly thread language mode to compilation cache (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, marja
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly thread language mode to compilation cache Fixes the TSAN issue. R=mstarzinger@chromium.org NOTRY=true BUG= Committed: https://crrev.com/eecde44f824a17fbb9a6fd871b4a5c9200055066 Cr-Commit-Position: refs/heads/master@{#26623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -46 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/compilation-cache.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/compilation-cache.cc View 6 chunks +12 lines, -8 lines 0 comments Download
M src/compiler.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M src/d8.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +7 lines, -5 lines 0 comments Download
M src/objects.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 7 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rossberg
5 years, 10 months ago (2015-02-12 16:13:42 UTC) #1
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-12 16:22:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923573002/1
5 years, 10 months ago (2015-02-12 16:25:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923573002/1
5 years, 10 months ago (2015-02-12 16:29:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 16:29:48 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 16:30:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eecde44f824a17fbb9a6fd871b4a5c9200055066
Cr-Commit-Position: refs/heads/master@{#26623}

Powered by Google App Engine
This is Rietveld 408576698