Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 923543003: Revert of I cannot remember what the race here actually was. (Closed)

Created:
5 years, 10 months ago by mtklein
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of I cannot remember what the race here actually was. (patchset #1 id:1 of https://codereview.chromium.org/922873002/) Reason for revert: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN/builds/1557/steps/dm/logs/stdio Original issue's description: > I cannot remember what the race here actually was. > > Removing SkTRacy will show us, or perhaps show us we already fixed the race. > > BUG=chromium:437511 > > No public API changes. > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/71409c83e69b387b3c5d567197d0421c36baf68d TBR=bungeman@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:437511 Committed: https://skia.googlesource.com/skia/+/0a62ad734ccd5e52f5e08afd64c3d758711315d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M include/core/SkDynamicAnnotations.h View 1 chunk +19 lines, -0 lines 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of I cannot remember what the race here actually was.
5 years, 10 months ago (2015-02-12 23:31:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923543003/1
5 years, 10 months ago (2015-02-12 23:32:04 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 23:32:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0a62ad734ccd5e52f5e08afd64c3d758711315d5

Powered by Google App Engine
This is Rietveld 408576698