Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: site/dev/contrib/testing.md

Issue 923543002: DM: document -r (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site/dev/contrib/testing.md
diff --git a/site/dev/contrib/testing.md b/site/dev/contrib/testing.md
index fb3d92d14085481e5bc9ec3520208f8f3bc64240..1ed56235bfef04d39511971f07f7558b21fd3d0f 100644
--- a/site/dev/contrib/testing.md
+++ b/site/dev/contrib/testing.md
@@ -135,9 +135,22 @@ If a test fails, DM will print out its assertion failures, both at the time
they happen and then again all together after everything is done running.
These failures are also included in the dm.json file.
-DM does not currently have a built-in image comparison facility, though we
-might add one. For now, you can use the skdiff tool to compare corresponding
-images from two runs of DM.
+DM has a simple facility to compare against the results of a previous run:
+~~~
+$ ./gyp_skia
+$ ninja -C out/Debug dm
+$ out/Debug/dm -w good
+
+ (do some work)
+
+$ ./gyp_skia
+$ ninja -C out/Debug dm
+$ out/Debug/dm -r good -w bad
+~~~
+When using `-r`, DM will display a failure for any test that didn't produce the
+same image as the `good` run.
+
+For anything fancier, I suggest using skdiff:
~~~
$ ./gyp_skia
$ ninja -C out/Debug dm
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698