Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 923533003: Fixing copresence/whispernet destructor order (Closed)

Created:
5 years, 10 months ago by Charlie
Modified:
5 years, 10 months ago
Reviewers:
rkc
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing copresence/whispernet destructor order Committed: https://crrev.com/25eb568df53f2c5c3d406ab7ecfa89702317b169 Cr-Commit-Position: refs/heads/master@{#316615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/copresence/copresence_api.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie
The CopresenceDelegate is specific about Whispernet lasting longer than CopresenceManager: https://code.google.com/p/chromium/codesearch#chromium/src/components/copresence/public/copresence_delegate.h&l=52 Accordingly, callbacks are unregistered ...
5 years, 10 months ago (2015-02-12 20:36:22 UTC) #2
rkc
lgtm
5 years, 10 months ago (2015-02-17 17:35:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/923533003/1
5 years, 10 months ago (2015-02-17 17:42:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 18:43:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:43:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25eb568df53f2c5c3d406ab7ecfa89702317b169
Cr-Commit-Position: refs/heads/master@{#316615}

Powered by Google App Engine
This is Rietveld 408576698