Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: upload_to_google_storage.py

Issue 923473002: [download_from_google_storage] Don't list ALL objects to check for ACLs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Remove spurious sha1 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « download_from_google_storage.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: upload_to_google_storage.py
diff --git a/upload_to_google_storage.py b/upload_to_google_storage.py
index 75db4174ee84a208ecf2b26206f4c14696a7d974..e81e0198f2a2f1f8b6d71acb1a91e2e7bf92676d 100755
--- a/upload_to_google_storage.py
+++ b/upload_to_google_storage.py
@@ -15,7 +15,6 @@ import sys
import threading
import time
-from download_from_google_storage import check_bucket_permissions
from download_from_google_storage import get_sha1
from download_from_google_storage import Gsutil
from download_from_google_storage import printer_worker
@@ -243,11 +242,6 @@ def main(args):
base_url = 'gs://%s' % options.bucket
- # Check we have a valid bucket with valid permissions.
- code = check_bucket_permissions(base_url, gsutil)
- if code:
- return code
-
return upload_to_google_storage(
input_filenames, base_url, gsutil, options.force, options.use_md5,
options.num_threads, options.skip_hashing)
« no previous file with comments | « download_from_google_storage.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698