Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2738)

Unified Diff: download_from_google_storage.py

Issue 923473002: [download_from_google_storage] Don't list ALL objects to check for ACLs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: download_from_google_storage.py
diff --git a/download_from_google_storage.py b/download_from_google_storage.py
index 0f53ea46e93be9297fb60fb3f99d39b7177f64d8..96b66c72cd775993d24c54647a78b07de49f5f5c 100755
--- a/download_from_google_storage.py
+++ b/download_from_google_storage.py
@@ -106,7 +106,7 @@ class Gsutil(object):
def check_bucket_permissions(base_url, gsutil):
hinoka 2015/02/12 18:03:54 I'd actually be okay with removing this entirely.
- code, _, ls_err = gsutil.check_call('ls', base_url)
+ code, _, ls_err = gsutil.check_call('ls', base_url + '/..')
Michael Moss 2015/02/12 16:39:21 Based on your description of "only ls the bucket i
if code != 0:
print >> sys.stderr, ls_err
if code == 403:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698