[Extensions] Remove the Infobar API

[Extensions] Remove the Infobar API

The infobar API was never really finished enough to launch, and has been
limping along for the past few years.  We should finally kill it.

BUG=458325
Committed: https://crrev.com/070802b11d6ecfb19d53e0c6398680862cf5b882
Cr-Commit-Position: refs/heads/master@{#316291}

[Devlin, 2015-02-13 00:31:45]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-02-13 00:36:38]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org, mek@chromium.org, pkasting@chromium.org,
rohitrao@chromium.org

[Devlin, 2015-02-13 00:36:39]

Hey all - sorry for the big patch.  Take a look when you can.

Ben - extensions docs stuff
Marijn - other extensions stuff
Peter - c/b/infobars, c/b/ui/views/infobars, components/infobars
Rohit - c/b/ui/cocoa/infobars

[Peter Kasting, 2015-02-13 02:45:44]

LGTM

https://codereview.chromium.org/923463003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_view_host.h (right):

https://codereview.chromium.org/923463003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_view_host.h:26: // example, this could be an
extension popup, infobar or dialog, but not a
Presumably the infobar part of this comment should disappear.

https://codereview.chromium.org/923463003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_view_host.h:115: void InsertInfobarCSS();
This is dead now and should be deleted.

[Marijn Kruisselbrink, 2015-02-13 17:12:44]

lgtm

https://codereview.chromium.org/923463003/diff/20001/extensions/common/view_t...
File extensions/common/view_type.h (left):

https://codereview.chromium.org/923463003/diff/20001/extensions/common/view_t...
extensions/common/view_type.h:21: VIEW_TYPE_EXTENSION_INFOBAR,
You should also remove infobar from the view-type enum in
chrome/common/extensions/api/extension.json

[rohitrao (ping after 24h), 2015-02-13 17:21:50]

chrome/browser/ui/cocoa LGTM

[not at google - send to devlin, 2015-02-13 17:27:32]

docs lgtm with some non trivial but easy changes.

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/intros/infobars.html (left):

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/infobars.html:1: <p>
Delete this file, but add a new one to articles/infobars.html with:

<p>
The <code>chrome.infobars</code> API is no longer supported. We recommend using
a $(ref:pageAction Page Action) instead.
</p>

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/public/extensions/infobars.html
(left):

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/public/extensions/infobars.html:1:
{{+partials.standard_extensions_api api:apis.extensions.infobars
intro:intros.infobars/}}
Change this to:

{{+partials.standard_extensions_article article:articles.infobars /}}

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/public/extensions/redirects.json
(left):

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/public/extensions/redirects.json:5:
"experimental_infobars": "infobars",
Let's be good web citizens and not delete publicly accessible files. I'll note
on the infobars.html template how to do that.

[Devlin, 2015-02-13 18:37:18]

New patchsets have been uploaded after l-g-t-m from
pkasting@chromium.org,mek@chromium.org,rohitrao@chromium.org,kalman@chromium.org

[Devlin, 2015-02-13 19:17:03]

Patchset #2 (id:40001) has been deleted

[Devlin, 2015-02-13 21:18:34]

https://codereview.chromium.org/923463003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_view_host.h (right):

https://codereview.chromium.org/923463003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_view_host.h:26: // example, this could be an
extension popup, infobar or dialog, but not a
On 2015/02/13 02:45:44, Peter Kasting wrote:
> Presumably the infobar part of this comment should disappear.

Done.

https://codereview.chromium.org/923463003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_view_host.h:115: void InsertInfobarCSS();
On 2015/02/13 02:45:44, Peter Kasting wrote:
> This is dead now and should be deleted.

Done.

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/intros/infobars.html (left):

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/intros/infobars.html:1: <p>
On 2015/02/13 17:27:32, kalman wrote:
> Delete this file, but add a new one to articles/infobars.html with:
> 
> <p>
> The <code>chrome.infobars</code> API is no longer supported. We recommend
using
> a $(ref:pageAction Page Action) instead.
> </p>

Done.

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/public/extensions/infobars.html
(left):

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/public/extensions/infobars.html:1:
{{+partials.standard_extensions_api api:apis.extensions.infobars
intro:intros.infobars/}}
On 2015/02/13 17:27:32, kalman wrote:
> Change this to:
> 
> {{+partials.standard_extensions_article article:articles.infobars /}}

Done.

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/docs/templates/public/extensions/redirects.json
(left):

https://codereview.chromium.org/923463003/diff/20001/chrome/common/extensions...
chrome/common/extensions/docs/templates/public/extensions/redirects.json:5:
"experimental_infobars": "infobars",
On 2015/02/13 17:27:32, kalman wrote:
> Let's be good web citizens and not delete publicly accessible files. I'll note
> on the infobars.html template how to do that.

Done.

https://codereview.chromium.org/923463003/diff/20001/extensions/common/view_t...
File extensions/common/view_type.h (left):

https://codereview.chromium.org/923463003/diff/20001/extensions/common/view_t...
extensions/common/view_type.h:21: VIEW_TYPE_EXTENSION_INFOBAR,
On 2015/02/13 17:12:43, Marijn Kruisselbrink wrote:
> You should also remove infobar from the view-type enum in
> chrome/common/extensions/api/extension.json

Done.

[Devlin, 2015-02-13 21:18:38]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-02-13 21:19:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/923463003/60001

[commit-bot: I haz the power, 2015-02-13 21:24:14]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-02-13 21:24:41]

Patchset 2 (id:??) landed as
https://crrev.com/070802b11d6ecfb19d53e0c6398680862cf5b882
Cr-Commit-Position: refs/heads/master@{#316291}