LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html - Issue 923443005: Disallow constructing the Notification object in a Service Worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html

Issue 923443005: Disallow constructing the Notification object in a Service Worker. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/notifications/resources/serviceworker-notification-constructor.js ('K') | « LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js ('k') | Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html

diff --git a/LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html b/LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html

new file mode 100644

index 0000000000000000000000000000000000000000..0ca9390af645eedcd1331d85e5d7a5756f998c62

--- /dev/null

+++ b/LayoutTests/http/tests/notifications/serviceworker-throw-constructor.html

@@ -0,0 +1,19 @@

+<!doctype html>

+<html>

+ <head>

+ <title>Notifications: Constructing a Notification should throw in a Service Worker.</title>

+ <script src="../resources/testharness.js"></script>

+ <script src="../resources/testharnessreport.js"></script>

+ <script src="../serviceworker/resources/test-helpers.js"></script>

+ </head>

+ <body>

+ <script>

+ // Tests that the constructing a Notification object in a Service Worker

Michael van Ouwerkerk 2015/02/16 18:16:09 s/that the/that/

Peter Beverloo 2015/02/16 18:23:57 Done.

+ // throws a TypeError per the specification. Developers should be using

+ // registration.showNotification() instead.

+ service_worker_test(

+ 'resources/serviceworker-notification-constructor.js',

+ 'Notification constructor behavior in a Service Worker.');

+ </script>

+ </body>

+</html>